From: Elijah Newren <newren@gmail.com>
To: "Rafael Ascensão" <rafa.almas@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Samuel Lijin <sxlijin@gmail.com>
Subject: Re: [bug?] clean: Demonstrate failure when used with paths
Date: Mon, 3 Jun 2019 13:32:13 -0700 [thread overview]
Message-ID: <CABPp-BFfYFj232cHd6_NTkEg1n8AOQ4Abm7ZrnLPWHJEDzUPsg@mail.gmail.com> (raw)
In-Reply-To: <CACUQV59ZQ=WLXa4iDw3nSJWnZpiqAYLOuoHKsNWj48uC=+k5KQ@mail.gmail.com>
On Mon, Jun 3, 2019 at 12:58 PM Rafael Ascensão <rafa.almas@gmail.com> wrote:
>
> I missed this RFC series which fixes this and others issues:
> https://public-inbox.org/git/20180405173446.32372-1-newren@gmail.com
>
> Cheers,
> Rafael Ascensão
Yeah, I've had cleaning that patch series up on my TODO list for quite
some time.
My vague recollection was that Peff pointed out a few things to clean
up in my patches, and also highlighted a few extra adjacent issues in
the surrounding underlying code...and when I started looking into
fixing the additional stuff it was slightly more complex and ugly (and
for some reason I didn't decide to just fix up and submit what I had
but was trying to fix everything in the area).
Also, briefly looking back at the cover letter and thread overview it
looks like no one ever attempted to shed light on the question I asked
in my RFC about what correct behavior was for one special case (i.e.
whether patches 5 & 6 of that series should be kept or whether they
should be dropped and patch 7 should be squashed into earlier
patches). Anyone have thoughts on that?
Elijah
prev parent reply other threads:[~2019-06-03 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 18:36 [bug?] clean: Demonstrate failure when used with paths Rafael Ascensão
2019-06-03 19:57 ` Rafael Ascensão
2019-06-03 20:32 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BFfYFj232cHd6_NTkEg1n8AOQ4Abm7ZrnLPWHJEDzUPsg@mail.gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rafa.almas@gmail.com \
--cc=sxlijin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).