From: Elijah Newren <newren@gmail.com>
To: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Alban Gruin" <alban.gruin@gmail.com>,
artagnon@gmail.com,
"Christian Couder" <christian.couder@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Rafael Ascensão" <rafa.almas@gmail.com>,
"Stephan Beyer" <s-beyer@gmx.net>,
"Thomas Gummerer" <t.gummerer@gmail.com>
Subject: Re: [GSoC][RFC v2] Improve consistency of sequencer commands
Date: Sat, 30 Mar 2019 10:13:56 -0700 [thread overview]
Message-ID: <CABPp-BFdg8M17YuhKOrtTS3Xeyf2TQB1+vBzDVTo5EzMebyLEA@mail.gmail.com> (raw)
In-Reply-To: <20190330084822.11285-1-rohit.ashiwal265@gmail.com>
On Sat, Mar 30, 2019 at 1:49 AM Rohit Ashiwal
<rohit.ashiwal265@gmail.com> wrote:
>
> Hi Elijah
>
> On 2019-03-30 0:38 UTC Elijah Newren <newren@gmail.com> wrote:
>
> > I'm curious if you're looking at an old version of the documentation
> > (...or maybe the documentation just isn't that clear?). Interactive
> > rebases have supported --signoff since commit a852ec7f273c ("rebase:
> > extend --signoff support", 2018-03-20)
>
> Oh~ after having a quick look at my currently installed version of git,
> it was 2.17.1, which has outdated man pages :sweat_smile:. Yes, you are
> correct, I'm sorry.
>
> Feeling dumb
> Rohit
Don't feel dumb. I like the initiative. Also, since you highlighted
it, there might be an issue with picking merge commits; either they
aren't affected by --signoff and should be, or the documentation
should be updated to mention they are handled too. So there is
actually something here, I think.
next prev parent reply other threads:[~2019-03-30 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 10:05 [GSoC] Introduction Rohit Ashiwal
2019-02-24 14:47 ` Johannes Schindelin
2019-02-25 6:50 ` Christian Couder
2019-02-25 11:35 ` Rohit Ashiwal
2019-02-25 20:21 ` Christian Couder
2019-02-25 21:09 ` Eric Sunshine
2019-03-22 15:11 ` [GSoC][RFC] Proposal: Improve consistency of sequencer commands Rohit Ashiwal
2019-03-23 22:17 ` Christian Couder
2019-03-24 1:21 ` Rohit Ashiwal
2019-03-24 1:07 ` Elijah Newren
2019-03-24 1:45 ` Rohit Ashiwal
2019-03-29 22:32 ` [GSoC][RFC v2] " Rohit Ashiwal
2019-03-29 23:25 ` Elijah Newren
2019-03-29 23:34 ` Rohit Ashiwal
2019-03-30 0:38 ` Elijah Newren
2019-03-30 8:48 ` Rohit Ashiwal
2019-03-30 17:13 ` Elijah Newren [this message]
2019-03-30 7:16 ` Christian Couder
2019-03-30 17:12 ` Elijah Newren
2019-04-05 21:31 ` [GSoC][RFC v3] Proposal: " Rohit Ashiwal
2019-04-07 7:15 ` Christian Couder
2019-04-07 12:16 ` Rohit Ashiwal
2019-04-07 23:07 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BFdg8M17YuhKOrtTS3Xeyf2TQB1+vBzDVTo5EzMebyLEA@mail.gmail.com \
--to=newren@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=artagnon@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=rafa.almas@gmail.com \
--cc=rohit.ashiwal265@gmail.com \
--cc=s-beyer@gmx.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).