From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 242AF1F55B for ; Fri, 22 May 2020 15:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730434AbgEVPy4 (ORCPT ); Fri, 22 May 2020 11:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730260AbgEVPyz (ORCPT ); Fri, 22 May 2020 11:54:55 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B46D7C061A0E for ; Fri, 22 May 2020 08:54:55 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id y85so9631164oie.11 for ; Fri, 22 May 2020 08:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0WX5tAdcjT0XssROWKUCmK+MKx9HByWovRhaEIEKmD0=; b=bUteTEdTazi8mOfoG6xtuvIIfMA62eXfNKo0/4rt+XWRln57N15/NU3LjE+ixKjMQC asOXbkZt7VVrm1aW9tHkwp59OrLqxOrD5qSXyETNrxAfs+UXoYNSRgzUIUeccXmOEziz 8ljuwNLjzgX9aN8K7If9SCJ6++Y7ZREngMOjsXo/9TPp3cCBw7ikt53JAyWxGL2Bw0Iy O2es70pxZxJLUKVt5il3eOXUG+E6yHCNrlGogsp+KUow2lQC+V8hwlBhy0c6SeY9zULG zSqRXxRck080QxR9N8x72Qq8OE6kFFAg9XqlrMjQosX+1qNzIRZ2Utufu8IFJBOqBqOB nVCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0WX5tAdcjT0XssROWKUCmK+MKx9HByWovRhaEIEKmD0=; b=SuIYjTrb7UvzgRqe/P7B8KxtLeawrGM0W319kFfejgt9CfLwp9I4rIwUcWcAdnlaI6 pfq6eaKZVegZT/XLJwsvIE/akOiEvXtVBG/cf0yEaiZ88JLItIu2v1qGmcg1wjjPqcY4 DNzpeR6bUW5phD0d+4wN71muyKb66XH4JCOg/J9nfUpJN4+yoZtM5/QK7gbYaxj7lr7U pFuvsCJ+3v9AJwSQXNGwtMgJqbPFSyDEo90vVMEms7jyQQxq216dbY5/JlB1eORX8OxD SaqBUj/N4+Z4oe6yhGl2Vru7icNgtDzHm0UUFH2M+HmeYfSnXjFi97PiVaTt2ZUEM+IS PcGA== X-Gm-Message-State: AOAM530J02but2RfcgONbzjnt6oPZJYxOgtMxXZCG9Gnt4TfmH6HamiP 7fPy6j+6ISAwcSKAzMDZK6LVAxcQA9f5p62HSTk= X-Google-Smtp-Source: ABdhPJwdO2ORCHl0ZOc/psRKu9rqwFNoGjdal5tCW2wGA2hY/yoPzXJUiqoSQGFf04gd+gbYWUBeZqlzgCK1vZfOR3g= X-Received: by 2002:aca:220f:: with SMTP id b15mr2918562oic.31.1590162894881; Fri, 22 May 2020 08:54:54 -0700 (PDT) MIME-Version: 1.0 References: <20200407141125.30872-1-phillip.wood123@gmail.com> <20200521101455.63484-1-phillip.wood123@gmail.com> In-Reply-To: <20200521101455.63484-1-phillip.wood123@gmail.com> From: Elijah Newren Date: Fri, 22 May 2020 08:54:43 -0700 Message-ID: Subject: Re: [PATCH v3 0/5] cleanup ra/rebase-i-more-options To: Phillip Wood Cc: Johannes Schindelin , Junio C Hamano , Rohit Ashiwal , Alban Gruin , Git Mailing List Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 21, 2020 at 3:15 AM Phillip Wood wrote: > > From: Phillip Wood > > Thanks for the feedback on v2, I've updated the documentation as > suggested by Elijah and made the style fixes suggested by Alban but > I've not changed read_author_script() for the reasons explained in > https://lore.kernel.org/git/c6a2711a-96c1-d7ac-9678-20c581408ef5@gmail.com All my questions were answered earlier; this round addressed my remaining feedback and I see no new issues. Reviewed-by: Elijah Newren