From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E62F71F47C for ; Sat, 21 Jan 2023 04:52:24 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=kpkhchjU; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbjAUEwX (ORCPT ); Fri, 20 Jan 2023 23:52:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjAUEwU (ORCPT ); Fri, 20 Jan 2023 23:52:20 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8722B6F33F for ; Fri, 20 Jan 2023 20:52:19 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id d30so10827414lfv.8 for ; Fri, 20 Jan 2023 20:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1ZuKgAO8vpPQP+LYu6QfxQsnORyoKpF1ne3Ej9wghEY=; b=kpkhchjUn0cpG+cJ0TQK+0qJ8vWxNWHd3YlyelahO7luaf8rzNU6wrKQA5A4q2O1Jr fLIjvBoga8Gqxx7MEcA8uMoZTBXONnSmKQAA9L97jqs6vqn0UNMptp4M5SJL3Y9IimtV naJhpG4eGetI0QwG6A61LEvdTei3+IlTFHkAxJ510TZQFMC3W+ExSIA0Kpob04ojItqL NosqAKgxRjYSir9n7c5ABLTfSSSjtuvGgmWHzCvTl+osJ2uPgqKrP/V+bYbUm4xaNVrS BlLZKRjlPxUEeD8qg0YYXqragDX2l5J0kAklMKMCNaMvrxFlltA+sym6okPENhAVlWDD +n1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ZuKgAO8vpPQP+LYu6QfxQsnORyoKpF1ne3Ej9wghEY=; b=qoIYmy8FkwMk8pxSe0PMrcl0wENUPT9tyBKXEd/KBHdoeXqSbFSQkMVU7aLwdbaGpC gEPppte+DLqZa1mVILCcQVXpROK/5jcLSvem13FPWuLDOI3d3mXGsALNyfv2tQqYYwaC 299OKslziQ6dzQ4veTLW9hjetd4Cwvdv6JEJLDrs97L3dp+kjJ6PM0WMiA/+jXRHIymY NK+UQFc643d5T4Vl3HmvN9zdL6fVFiNVg4QLu1Vc3ay5zVfJsusKBXdOSI9YoFiriJ98 HF+eZJMtBMSYpGTJFHk5WzT6f5Pc+0lIw3D9KSdTgxlGj/50WSKnQTUjEPc6/fq7Ym1A 6aWw== X-Gm-Message-State: AFqh2kr2l7hwnVF+3IimD8C7itUsETkGi+J8zfSXr2TAqRjSyycW9yhV U+oEMFAPRAGt0FT9uRGT2romCaKoIBKt+MEnDW9XOslv X-Google-Smtp-Source: AMrXdXukU2mMXfQ81/yllNFOSkRqgtD/hKEVH8FDD4JL9BMWBggla6acJXKyZmbPEYt1rHIw/61fIihJUXam1Ic0NWI= X-Received: by 2002:a19:7601:0:b0:4ca:fa6a:1506 with SMTP id c1-20020a197601000000b004cafa6a1506mr1230581lff.32.1674276737618; Fri, 20 Jan 2023 20:52:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Elijah Newren Date: Fri, 20 Jan 2023 20:52:05 -0800 Message-ID: Subject: Re: [PATCH v2 1/2] rebase: remove completely useless -C option To: Junio C Hamano Cc: Elijah Newren via GitGitGadget , git@vger.kernel.org, Derrick Stolee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jan 20, 2023 at 8:16 AM Junio C Hamano wrote: > > Elijah Newren writes: > > > On Fri, Jan 20, 2023 at 4:05 AM Junio C Hamano wrote: > >> ... > >> That is, even when a patch does not cleanly apply with full context > >> in the incoming diff, by requiring *smaller* number of lines to > >> match, the diff *could* be forced to apply with reduced precision? > > > > Oh! Reducing the number of lines of context to pay attention to never > > even occurred to me for whatever reason. I'll drop the patch. > > Yup. "completely useless" on the title is less than half correct, > but still correct for a minor use case where -C is used to use > *more* context lines than the default. > > We could update "rebase --apply" codepath to increase the context > lines generated by format-patch. That would make the "completely > useless" totally incorrect ;-) haha :-) I'd probably go for that, but since in my mind the plan is still to deprecate and remove the apply backend as you suggested at [1], I'm not particularly motivated to improve/extend options specific to the apply backend of rebase. [1] https://lore.kernel.org/git/xmqqa78d2qmk.fsf@gitster-ct.c.googlers.com/