From: Elijah Newren <newren@gmail.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Victoria Dye" <vdye@github.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] ls-files: add %(skipworktree) atom to format option
Date: Fri, 13 Jan 2023 19:00:32 -0800 [thread overview]
Message-ID: <CABPp-BFEKqU2YWEk=NT2xA_cO=rj_EgjqzYsuxDGwPon18dq8Q@mail.gmail.com> (raw)
In-Reply-To: <CAOLTT8RNWJLA_UvoMA_MktkEmLSjJrx7E6Khy97cHhVFXPQD2A@mail.gmail.com>
On Fri, Jan 13, 2023 at 8:50 AM ZheNing Hu <adlternative@gmail.com> wrote:
>
> Elijah Newren <newren@gmail.com> 于2023年1月12日周四 18:00写道:
> >
> > On Wed, Jan 11, 2023 at 7:42 AM ZheNing Hu via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:
> > >
[...]
> > The "and removed from working tree" portion of this sentence is
> > superfluous. (And actually makes it harder to understand, I had to
> > try to think through a bunch of cases to try to figure out why you
> > might be trying to add some extra qualifier.)
> >
>
> I just quoted the definition of SKIP_WORKTREE from
> Documentation/technical/sparse-checkout.txt:
>
> SKIP_WORKTREE: When tracked files do not match the sparse specification and
> are removed from the working tree, the file in the index is marked
> with a SKIP_WORKTREE bit.
Ah, thanks for pointing out the error. This should probably be reworded to:
SKIP_WORKTREE: When a tracked file which is unmodified does not match
the sparsity patterns, it is removed from the working tree and
the file in the index is marked with a SKIP_WORKTREE bit (to
distinguish the missing file from an unstaged deletion).
[...]
> To be honest, right now I think %(skipworktree) just refines the
> --format option's ability to read the index entry SKIP_WORKTREE
> flag bits. It is probably still worth keeping.
I'm not opposed to the idea of a special skipworktree formatting in
conjunction with ls-files' --format option, so long as it has
alternate rationale and isn't worded to suggest it supersedes `git
ls-files -t` for all sparse-checkout uses.
next prev parent reply other threads:[~2023-01-14 3:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 15:42 [PATCH] ls-files: add %(skipworktree) atom to format option ZheNing Hu via GitGitGadget
2023-01-12 10:00 ` Elijah Newren
2023-01-12 19:58 ` Junio C Hamano
2023-01-13 4:43 ` Elijah Newren
2023-01-13 17:07 ` ZheNing Hu
2023-01-13 16:50 ` ZheNing Hu
2023-01-14 3:00 ` Elijah Newren [this message]
2023-01-12 10:07 ` Ævar Arnfjörð Bjarmason
2023-01-13 16:59 ` ZheNing Hu
2023-01-19 17:34 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget
2023-01-19 17:34 ` [PATCH v2 1/2] docs: fix sparse-checkout docs link ZheNing Hu via GitGitGadget
2023-01-20 5:12 ` Elijah Newren
2023-01-20 9:35 ` Martin Ågren
2023-01-23 15:16 ` ZheNing Hu
2023-01-23 15:15 ` ZheNing Hu
2023-01-19 17:34 ` [PATCH v2 2/2] ls-files: add %(skipworktree) atom to format option ZheNing Hu via GitGitGadget
2023-01-20 5:30 ` Elijah Newren
2023-01-20 16:34 ` Junio C Hamano
2023-01-23 15:35 ` ZheNing Hu
2023-01-23 22:39 ` Junio C Hamano
2023-01-23 15:33 ` ZheNing Hu
2023-02-04 16:16 ` [PATCH v3 0/2] " ZheNing Hu via GitGitGadget
2023-02-04 16:16 ` [PATCH v3 1/2] docs: fix sparse-checkout docs link ZheNing Hu via GitGitGadget
2023-02-04 16:16 ` [PATCH v3 2/2] ls-files: add %(skipworktree) atom to format option ZheNing Hu via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BFEKqU2YWEk=NT2xA_cO=rj_EgjqzYsuxDGwPon18dq8Q@mail.gmail.com' \
--to=newren@gmail.com \
--cc=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).