From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
Date: Mon, 3 Jan 2022 17:48:07 -0800 [thread overview]
Message-ID: <CABPp-BF9XpxE2wLgAzZe0CR3NAAw0R9im4HBBm=BgirpNZOpAA@mail.gmail.com> (raw)
In-Reply-To: <xmqqtuenkk4k.fsf@gitster.g>
On Sat, Jan 1, 2022 at 5:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Elijah Newren <newren@gmail.com>
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
> > ---
> > t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
>
> Is this continuation of [*1*]?
Ah, yes it is.
> I think it will go away when dee839a2 (format-patch: mark
> rev_info with UNLEAK, 2021-12-16) is merged.
Can we fast track that patch? The patch looks good to me. In
general, though, I would think the simpler fix of just removing the
TEST_PASSES_SANITIZE_LEAK=true would be safer and could be fast
tracked.
I'm sorry I missed these potential problems cropping up when I
reviewed the earlier series (which added these flags to a bunch of
scripts). I just didn't foresee these consequences.
prev parent reply other threads:[~2022-01-04 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 5:15 [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does Elijah Newren via GitGitGadget
2022-01-01 23:17 ` Johannes Schindelin
2022-01-02 1:21 ` Junio C Hamano
2022-01-04 1:48 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BF9XpxE2wLgAzZe0CR3NAAw0R9im4HBBm=BgirpNZOpAA@mail.gmail.com' \
--to=newren@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).