From: Elijah Newren <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Elijah Newren via GitGitGadget <email@example.com>, Git Mailing List <firstname.lastname@example.org>, Matheus Tavares Bernardino <email@example.com>, Derrick Stolee <firstname.lastname@example.org> Subject: Re: [PATCH 0/3] Fix stash apply in sparse checkouts (and a submodule test) Date: Wed, 25 Nov 2020 21:31:56 -0800 [thread overview] Message-ID: <CABPp-BF5GgpXdo+8TwBPPtxJWot+6h+9oLkWMTtiiqy_uNDKMw@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Wed, Nov 25, 2020 at 2:14 PM Junio C Hamano <firstname.lastname@example.org> wrote: > > "Elijah Newren via GitGitGadget" <email@example.com> writes: > > > Heavier usage of sparse-checkouts at $DAYJOB is commencing. And an issue > > with git stash apply was found. > > > > git stash's implementation as a pipeline of forked commands presents some > > problems, especially when implemented atop of three commands that all behave > > differently in the presence of sparse checkouts. Add a testcase > > demonstrating some issues with git stash apply in a repository with a > > different set of sparse-checkout patterns at apply vs create time, clean up > > the relevant section of git stash code, and incidentally fix a submodule > > testcase unrelated to sparse checkouts. Provide some detailed commit > > messages explaining the issues along the way. > > > > NOTE: I found a couple minor issues with other commands in sparse checkouts > > while debugging this issue, but I don't yet have fixes for them and I can > > submit them separately. > > Any comments on this from reviewers? The second patch is a but too > busy looking and I am having a bit of trouble convincing myself that > it is doing the right thing. Hmm, that diff is a little hard to read. It's a removal of two functions, and an addition of a new one, but the way the diff reads it looks like I'm modifying the existing functions because it catches some comment line markers and thinks they're similar. Maybe it'd be easier to read if I inserted that function elsewhere in the file? I'll send a re-roll with that and add a comment or two to help explain it (as well as fix up the small issues Chris highlighted).
next prev parent reply other threads:[~2020-11-26 5:35 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-20 16:53 Elijah Newren via GitGitGadget 2020-11-20 16:53 ` [PATCH 1/3] t7012: add a testcase demonstrating stash apply bugs in sparse checkouts Elijah Newren via GitGitGadget 2020-11-20 16:53 ` [PATCH 2/3] stash: remove unnecessary process forking Elijah Newren via GitGitGadget 2020-11-20 16:53 ` [PATCH 3/3] stash: fix stash application in sparse-checkouts Elijah Newren via GitGitGadget 2020-11-21 12:47 ` Chris Torek 2020-11-22 3:47 ` Elijah Newren 2020-11-25 22:14 ` [PATCH 0/3] Fix stash apply in sparse checkouts (and a submodule test) Junio C Hamano 2020-11-26 5:31 ` Elijah Newren [this message] 2020-12-01 22:25 ` [PATCH v2 " Elijah Newren via GitGitGadget 2020-12-01 22:25 ` [PATCH v2 1/3] t7012: add a testcase demonstrating stash apply bugs in sparse checkouts Elijah Newren via GitGitGadget 2020-12-01 22:25 ` [PATCH v2 2/3] stash: remove unnecessary process forking Elijah Newren via GitGitGadget 2020-12-01 23:02 ` Junio C Hamano 2020-12-02 16:09 ` Elijah Newren 2020-12-01 22:25 ` [PATCH v2 3/3] stash: fix stash application in sparse-checkouts Elijah Newren via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABPp-BF5GgpXdo+8TwBPPtxJWot+6h+9oLkWMTtiiqy_uNDKMw@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/3] Fix stash apply in sparse checkouts (and a submodule test)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).