git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* repeated empty section in config of repository
@ 2019-04-10 11:51 Kurt Ablinger
  2019-04-10 14:57 ` SZEDER Gábor
  2019-04-10 16:35 ` Elijah Newren
  0 siblings, 2 replies; 3+ messages in thread
From: Kurt Ablinger @ 2019-04-10 11:51 UTC (permalink / raw)
  To: git@vger.kernel.org

Hello, 

I am not sure if this can be problem - at least it is proably not correct:

when adding a key to an empty section and deleting the key so that the section is empty again,
every add adds the section-name again - example:

git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
[gc]

git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
[gc]
[gc]

git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
[gc]
[gc]
[gc]

Git-version is 2.17.0
Linux - Cent/OS: 2.6.32-754.10.1.el6.x86_64 - GNU/Linux

Greetings
Kurt


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: repeated empty section in config of repository
  2019-04-10 11:51 repeated empty section in config of repository Kurt Ablinger
@ 2019-04-10 14:57 ` SZEDER Gábor
  2019-04-10 16:35 ` Elijah Newren
  1 sibling, 0 replies; 3+ messages in thread
From: SZEDER Gábor @ 2019-04-10 14:57 UTC (permalink / raw)
  To: Kurt Ablinger; +Cc: git@vger.kernel.org

On Wed, Apr 10, 2019 at 11:51:03AM +0000, Kurt Ablinger wrote:
> Hello, 
> 
> I am not sure if this can be problem - at least it is proably not correct:
> 
> when adding a key to an empty section and deleting the key so that the section is empty again,
> every add adds the section-name again - example:
> 
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
> 
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
> [gc]
> 
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
> [gc]
> [gc]
> 
> Git-version is 2.17.0
> Linux - Cent/OS: 2.6.32-754.10.1.el6.x86_64 - GNU/Linux

This was a known issue, but not a serious one, in the sense that it
didn't affect correctness of configuration parsing.

It was mostly fixed in v2.18.0.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: repeated empty section in config of repository
  2019-04-10 11:51 repeated empty section in config of repository Kurt Ablinger
  2019-04-10 14:57 ` SZEDER Gábor
@ 2019-04-10 16:35 ` Elijah Newren
  1 sibling, 0 replies; 3+ messages in thread
From: Elijah Newren @ 2019-04-10 16:35 UTC (permalink / raw)
  To: Kurt Ablinger; +Cc: git@vger.kernel.org

On Wed, Apr 10, 2019 at 9:08 AM Kurt Ablinger <kurt.ablinger@bs-ag.com> wrote:
>
> Hello,
>
> I am not sure if this can be problem - at least it is proably not correct:
>
> when adding a key to an empty section and deleting the key so that the section is empty again,
> every add adds the section-name again - example:
>
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
>
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
> [gc]
>
> git config gc.autoDetach false ; git config --unset gc.autoDetach ; cat config
> [gc]
> [gc]
> [gc]
>
> Git-version is 2.17.0
> Linux - Cent/OS: 2.6.32-754.10.1.el6.x86_64 - GNU/Linux
>
> Greetings
> Kurt

I believe this was fixed by 4f4d0b42bae8 ("Merge branch
'js/empty-config-section-fix'", 2018-05-08) in git-2.18.0.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-10 16:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 11:51 repeated empty section in config of repository Kurt Ablinger
2019-04-10 14:57 ` SZEDER Gábor
2019-04-10 16:35 ` Elijah Newren

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).