From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 4DF4D1F54E for ; Sat, 20 Aug 2022 00:11:51 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oeG+ulSQ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244831AbiHTALH (ORCPT ); Fri, 19 Aug 2022 20:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233206AbiHTALF (ORCPT ); Fri, 19 Aug 2022 20:11:05 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF64E1155BB for ; Fri, 19 Aug 2022 17:11:02 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id c9so3232439qkk.6 for ; Fri, 19 Aug 2022 17:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=D8GSGIPw3sXst4hvRB6qX9Yt/JLmmcTLkkHjUf4BphA=; b=oeG+ulSQXK96CIoXNo4xkbZ9cmXMdySBAtWHwqMsbYhDPdOMy8Rkv4LsnYoVLdxNCa W2s2orUE8MXjLP48K3gkhU8bEuqpxuX6sgqDNqNaEe9EixS/jj7m0VHB1K6lmVVxDnmY xYQN4xenbDA2pAAGakdMldQQwRQyOlgiJtJJVv4W1pjCjrjHAtlNyBxhZR7/32cFXmjq zOQZx2pQIYxvrYklM+5YVJWp5ikg6dx3yshUIvGo+kMn2Ma6ouoUV+Vl4CSVtgo9WVOK aZVzErKCv88AZ85brx5xkJbVFYZhemlBxaZNS1ByCHhGrHLZLD23Wv57lqvI6Gz26OFa XYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=D8GSGIPw3sXst4hvRB6qX9Yt/JLmmcTLkkHjUf4BphA=; b=CnVMlioYDn7oZqNh1bnE0GdOMMjCsp25Df9kfJIEC2jPHdpRbrpMOaK2h/J1HxjX9W cneNTDmM5dOSg/Z14Ui/gPTLL54fdCJgwgJLPdfnDEI/01yV+ij4U7kzRRS+nZjWjiqz 0yD3uHzs0JIrZTvCMfha4CTXveHEURVBuAitvB+aJDqafpd2CCLhBqjNo6dBoHfypajj 4jDoNskp3aJTUOH5lEqcio/uL5Byio3qZicTVFfWC5qk3w4w4243af9IKGFku7LbF8K/ K3fGhQST31x8XcUi+yctY7Lylria3qF3XqCFqqZyd/KrWzaHPsJoA7P6pX7LO4wWjnRn NzsA== X-Gm-Message-State: ACgBeo2I9eSdvUMXuEZZ3sfEJbGVhSPvfb6YhU8vTBbdUt0zxIQdZnyk yCpZHAWvikCHw+FUY6cGR3lnh5BylJUDVKCjUf4= X-Google-Smtp-Source: AA6agR4W2s6Hjk3mFTYwR81JzRszh5b1eVDwIWVqm6PrbgJNbFKq7akw0sUYzQPyrs8u5oNEvxZqiYBCw+d4TTW66Dk= X-Received: by 2002:a05:620a:1902:b0:6b8:d90e:cef7 with SMTP id bj2-20020a05620a190200b006b8d90ecef7mr6858530qkb.131.1660954261807; Fri, 19 Aug 2022 17:11:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Elijah Newren Date: Fri, 19 Aug 2022 17:10:50 -0700 Message-ID: Subject: Re: [PATCH v3 3/3] revision: allow --ancestry-path to take an argument To: Junio C Hamano Cc: Elijah Newren via GitGitGadget , Git Mailing List , Derrick Stolee , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Eric Sunshine , Jonathan Tan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 19, 2022 at 10:54 AM Junio C Hamano wrote: > > "Elijah Newren via GitGitGadget" writes: > > > ancestry_path:1, > > + > > + /* True if --ancestry-path was specified without an > > + * argument. The bottom revisions are implicitly > > + * the arguments in this case. > > + */ > > + ancestry_path_implicit_bottoms:1, > > The above comment explains why this is called "implicit" very well. > The earlier round used "need", but the word missed the essense (i.e. > ancestry_path argument is implicit and not given, so we need to > compute bottoms and use them instead). The new name is certainly > better. Yep, I agree, but all credit for this improvement goes to Jonathan; this was one of many good suggestions in his careful review.