From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 752F21F4BD for ; Tue, 1 Oct 2019 19:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbfJATj7 (ORCPT ); Tue, 1 Oct 2019 15:39:59 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:37561 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfJATj7 (ORCPT ); Tue, 1 Oct 2019 15:39:59 -0400 Received: by mail-vs1-f65.google.com with SMTP id p13so10241508vsr.4 for ; Tue, 01 Oct 2019 12:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TwM+lNoEwqJwnFaboum4Yb0F+VsDLuep/3woZCUb4/o=; b=IFjejnlJ0DhV624gayFU6pwoVcHXhot93VgKtL0lkymPkDEinr5j0OCfAoDTXX4uTA xGdbikyEkXKHiYK0/8CP0RKNkLHlzvGA3GQzqDUihuvzw9fk3cx8wrpZBgF/YtH7ybqq S0V+esCjkWDsfaNTzDW/gLJfTCDQuqrN0C08SPihTVSD2jZbjze14y69NsqZuAwF9TFJ gOW9aIVx4bGEoqHD0zwxG97ZHDh3/gHtP0QJYNfQVDZgpHdhpZ5My6gtmemOp6b/pGwX 4av9BFT8Yo6LjvF9dlAJyNfdZm+pxUaZe8k2pC/NxG3rxieI+VnejW2Mvsl4WNd/vvmT j53A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TwM+lNoEwqJwnFaboum4Yb0F+VsDLuep/3woZCUb4/o=; b=dR258gqdd71qQNkEHkfAxNDcgPxPESnDccdLlMJR8uEFH5YVsO6sfGtwxprrI0bc46 xWDNcx1Pde+FSZXkySCQ0zP0ln8otAp3zqiQw8X3RPATMAQXqXM8aJjFVtAA8WRyNN4B p8HGQL8dacn1EmUm3ck8tBZxYBQYHaQTBIV5/ZGhLnXVTYy4r05LwGJDjFT4klUCjcCZ h13XqsxxcVVugsng75b++LU/VjfLnu2zfJOyTL3DH1yPMu4LqC0tagIntRxS7gXBmAdt H8R0yXc2Iv9wJGLRkEqYezInYNLbVdGv8f/tPz4maZwIuNkd4dX1kl1I/cJPJEVzR7JT mEaQ== X-Gm-Message-State: APjAAAWhp0DA2iqS78Mkuqj1Aa4R2HqvCt1i9oWihBK/NrtQNzk6H/28 jvPnqQVK0MtaOnwJcnDiv5btZLY4iMCCoIcQBHA1PwsD X-Google-Smtp-Source: APXvYqycmNQmBChki2pkp7+NigEst9BbHY8AA1X67MRsMq3t1JNtGZeB3itdKKHrNEFTiWc7air7BtzpryQ5to8WXYo= X-Received: by 2002:a67:c11b:: with SMTP id d27mr14497634vsj.175.1569958796228; Tue, 01 Oct 2019 12:39:56 -0700 (PDT) MIME-Version: 1.0 References: <20191001184049.GA30113@generichostname> <20191001185524.18772-1-newren@gmail.com> <20191001193510.GA43899@generichostname> In-Reply-To: <20191001193510.GA43899@generichostname> From: Elijah Newren Date: Tue, 1 Oct 2019 12:39:44 -0700 Message-ID: Subject: Re: [PATCH v3] dir: special case check for the possibility that pathspec is NULL To: Denton Liu Cc: Git Mailing List , Junio C Hamano , =?UTF-8?Q?SZEDER_G=C3=A1bor?= Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 1, 2019 at 12:35 PM Denton Liu wrote: > > Hi Elijah, > > Sorry for dragging out this thread for so long... > > On Tue, Oct 01, 2019 at 11:55:24AM -0700, Elijah Newren wrote: > > [...] > > > diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh > > index 192c94eccd..a840919967 100755 > > --- a/t/t0050-filesystem.sh > > +++ b/t/t0050-filesystem.sh > > @@ -131,4 +131,25 @@ $test_unicode 'merge (silent unicode normalization)' ' > > I had to change the 25 to a 24 for this to apply cleanly. > > > git merge topic > > ' > > > > +test_expect_success CASE_INSENSITIVE_FS 'checkout with no pathspec and a case insensitive fs' ' > > + git init repo && > > + ( > > + cd repo && > > + > > + >Gitweb && > > + git add Gitweb && > > + git commit -m "add Gitweb" && > > + > > + git checkout --orphan todo && > > + git reset --hard && > > + mkdir -p gitweb/subdir && > > + >gitweb/subdir/file && > > + git add gitweb && > > + git commit -m "add gitweb/subdir/file" && > > + > > + git checkout master > > + ) > > +' > > + > > test_done > > Just wondering, how did you generate this patch? Did you manually edit > the last patch and resend it or is this a bug in our diff machinery? I manually edited because it "was so simple" and of course just compounded the problem because I didn't fix the count, as you pointed out. Gah. Thanks for checking. Clearly, I'm bouncing between too many things this morning, and need to wait until I'm not so distracted and rushing so I don't mess things up. I'll sound out a v4 in a few hours when I've cleaned a few other things off my plate.