From: Elijah Newren <newren@gmail.com> To: Derrick Stolee <stolee@gmail.com> Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>, Git Mailing List <git@vger.kernel.org>, Derrick Stolee <dstolee@microsoft.com> Subject: Re: [PATCH 7/7] sparse-checkout: provide a new update subcommand Date: Mon, 16 Mar 2020 10:05:37 -0700 Message-ID: <CABPp-BE=VdSAfAWR_2KivXbGOYknhJ=4sbRjVPAS+URNgjLFPQ@mail.gmail.com> (raw) In-Reply-To: <ee9e8bc6-252f-8ac5-e769-26302f3eb1eb@gmail.com> On Sun, Mar 15, 2020 at 9:24 AM Derrick Stolee <stolee@gmail.com> wrote: > > On 3/14/2020 3:11 AM, Elijah Newren via GitGitGadget wrote: > > From: Elijah Newren <newren@gmail.com> > > > > If commands like merge or rebase materialize files as part of their work, > > or a previous sparse-checkout command failed to update individual files > > due to dirty changes, users may want a command to simply 'reapply' the > > sparsity rules. Provide one. > > I was actually thinking "refresh" would be a better name, but also you > use "reapply" which is good, too. I'm concerned that "update" may imply > that the sparse-checkout patterns can change, but you really mean to > re-do the work from a previous "git sparse-checkout (set|add)". > > I also thought of "reset" but that would be a confusing overload. Makes sense; I'll switch it over to "reapply". > > Signed-off-by: Elijah Newren <newren@gmail.com> > > --- > > Documentation/git-sparse-checkout.txt | 10 ++++++++++ > > builtin/sparse-checkout.c | 10 +++++++++- > > 2 files changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/git-sparse-checkout.txt b/Documentation/git-sparse-checkout.txt > > index c0342e53938..27f4392489f 100644 > > --- a/Documentation/git-sparse-checkout.txt > > +++ b/Documentation/git-sparse-checkout.txt > > @@ -70,6 +70,16 @@ C-style quoted strings. > > `core.sparseCheckoutCone` is enabled, the given patterns are interpreted > > as directory names as in the 'set' subcommand. > > > > +'update':: > > + Update the sparseness of paths in the working tree based on the > > + existing patterns. Commands like merge or rebase can materialize > > + paths to do their work (e.g. in order to show you a conflict), and > > + other sparse-checkout commands might fail to sparsify an individual > > + file (e.g. because it has unstaged changes or conflicts). In such > > + cases, it can make sense to run `git sparse-checkout update` later > > + after cleaning up affected paths (e.g. resolving conflicts, undoing > > + or committing changes, etc.). > > + > > 'disable':: > > Disable the `core.sparseCheckout` config setting, and restore the > > working directory to include all files. Leaves the sparse-checkout > > diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c > > index 5d3ec2e6be9..2ae21011dfd 100644 > > --- a/builtin/sparse-checkout.c > > +++ b/builtin/sparse-checkout.c > > @@ -18,7 +18,7 @@ > > static const char *empty_base = ""; > > > > static char const * const builtin_sparse_checkout_usage[] = { > > - N_("git sparse-checkout (init|list|set|add|disable) <options>"), > > + N_("git sparse-checkout (init|list|set|add|update|disable) <options>"), > > NULL > > }; > > > > @@ -552,6 +552,12 @@ static int sparse_checkout_set(int argc, const char **argv, const char *prefix, > > return modify_pattern_list(argc, argv, m); > > } > > > > +static int sparse_checkout_update(int argc, const char **argv) > > +{ > > + repo_read_index(the_repository); > > + return update_working_directory(NULL); > > +} > > + > > Short and sweet! I suppose my earlier comment about whether > repo_read_index() was necessary is answered here. Perhaps it > should be part of update_working_directory()? (And pass a > repository pointer to it?) Good question. Is there a chance we want to make update_working_directory() available to other areas of git outside of sparse-checkout.c? If so, potentially re-reading the index might not be friendly, but if sparse-checkout.c is going to remain the only caller then it probably makes sense to move it inside. > > static int sparse_checkout_disable(int argc, const char **argv) > > { > > struct pattern_list pl; > > @@ -601,6 +607,8 @@ int cmd_sparse_checkout(int argc, const char **argv, const char *prefix) > > return sparse_checkout_set(argc, argv, prefix, REPLACE); > > if (!strcmp(argv[0], "add")) > > return sparse_checkout_set(argc, argv, prefix, ADD); > > + if (!strcmp(argv[0], "update")) > > + return sparse_checkout_update(argc, argv); > > if (!strcmp(argv[0], "disable")) > > return sparse_checkout_disable(argc, argv); > > }
next prev parent reply other threads:[~2020-03-16 17:05 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-14 7:11 [PATCH 0/7] Sparse checkout improvements -- improved sparsity updating Elijah Newren via GitGitGadget 2020-03-14 7:11 ` [PATCH 1/7] unpack-trees: fix minor typo in comment Elijah Newren via GitGitGadget 2020-03-14 7:11 ` [PATCH 2/7] t1091: make some tests a little more defensive against failures Elijah Newren via GitGitGadget 2020-03-14 7:11 ` [PATCH 3/7] unpack-trees: allow check_updates() to work on a different index Elijah Newren via GitGitGadget 2020-03-14 7:11 ` [PATCH 4/7] unpack-trees: do not mark a dirty path with SKIP_WORKTREE Elijah Newren via GitGitGadget 2020-03-15 14:39 ` Derrick Stolee 2020-03-14 7:11 ` [PATCH 5/7] unpack-trees: add a new update_sparsity() function Elijah Newren via GitGitGadget 2020-03-15 18:17 ` Derrick Stolee 2020-03-16 20:24 ` Elijah Newren 2020-03-14 7:11 ` [PATCH 6/7] sparse-checkout: use " Elijah Newren via GitGitGadget 2020-03-15 16:19 ` Derrick Stolee 2020-03-16 17:02 ` Elijah Newren 2020-03-14 7:11 ` [PATCH 7/7] sparse-checkout: provide a new update subcommand Elijah Newren via GitGitGadget 2020-03-15 16:24 ` Derrick Stolee 2020-03-16 17:05 ` Elijah Newren [this message] 2020-03-16 17:18 ` Derrick Stolee 2020-03-16 19:23 ` Elijah Newren 2020-03-15 12:26 ` [PATCH 0/7] Sparse checkout improvements -- improved sparsity updating Derrick Stolee 2020-03-21 17:59 ` [PATCH v2 00/18] " Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 01/18] unpack-trees: fix minor typo in comment Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 02/18] unpack-trees: remove unused error type Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 03/18] unpack-trees: simplify verify_absent_sparse() Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 04/18] unpack-trees: simplify pattern_list freeing Elijah Newren via GitGitGadget 2020-03-23 15:57 ` Derrick Stolee 2020-03-21 17:59 ` [PATCH v2 05/18] t1091: make some tests a little more defensive against failures Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 06/18] unpack-trees: allow check_updates() to work on a different index Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 07/18] unpack-trees: do not mark a dirty path with SKIP_WORKTREE Elijah Newren via GitGitGadget 2020-03-21 17:59 ` [PATCH v2 08/18] unpack-trees: pull sparse-checkout pattern reading into a new function Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 09/18] unpack-trees: add a new update_sparsity() function Elijah Newren via GitGitGadget 2020-03-23 18:02 ` Derrick Stolee 2020-03-23 18:10 ` Elijah Newren 2020-03-23 18:21 ` Derrick Stolee 2020-03-23 20:24 ` Junio C Hamano 2020-03-21 18:00 ` [PATCH v2 10/18] sparse-checkout: use " Elijah Newren via GitGitGadget 2020-03-23 18:07 ` Derrick Stolee 2020-03-23 18:14 ` Elijah Newren 2020-03-23 18:22 ` Derrick Stolee 2020-03-21 18:00 ` [PATCH v2 11/18] sparse-checkout: use improved unpack_trees porcelain messages Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 12/18] unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlier Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 13/18] unpack-trees: rename ERROR_* fields meant for warnings to WARNING_* Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 14/18] unpack-trees: split display_error_msgs() into two Elijah Newren via GitGitGadget 2020-03-23 18:32 ` Derrick Stolee 2020-03-21 18:00 ` [PATCH v2 15/18] unpack-trees: make sparse path messages sound like warnings Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 16/18] unpack-trees: provide warnings on sparse updates for unmerged paths too Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 17/18] unpack-trees: failure to set SKIP_WORKTREE bits always just a warning Elijah Newren via GitGitGadget 2020-03-21 18:00 ` [PATCH v2 18/18] sparse-checkout: provide a new reapply subcommand Elijah Newren via GitGitGadget 2020-03-23 18:40 ` Derrick Stolee 2020-03-23 18:41 ` [PATCH v2 00/18] Sparse checkout improvements -- improved sparsity updating Derrick Stolee 2020-03-23 20:26 ` Junio C Hamano 2020-03-27 0:48 ` [PATCH v3 " Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 01/18] unpack-trees: fix minor typo in comment Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 02/18] unpack-trees: remove unused error type Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 03/18] unpack-trees: simplify verify_absent_sparse() Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 04/18] unpack-trees: simplify pattern_list freeing Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 05/18] t1091: make some tests a little more defensive against failures Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 06/18] unpack-trees: allow check_updates() to work on a different index Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 07/18] unpack-trees: do not mark a dirty path with SKIP_WORKTREE Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 08/18] unpack-trees: pull sparse-checkout pattern reading into a new function Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 09/18] unpack-trees: add a new update_sparsity() function Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 10/18] sparse-checkout: use " Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 11/18] sparse-checkout: use improved unpack_trees porcelain messages Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 12/18] unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlier Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 13/18] unpack-trees: rename ERROR_* fields meant for warnings to WARNING_* Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 14/18] unpack-trees: split display_error_msgs() into two Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 15/18] unpack-trees: make sparse path messages sound like warnings Elijah Newren via GitGitGadget 2020-03-27 0:48 ` [PATCH v3 16/18] unpack-trees: provide warnings on sparse updates for unmerged paths too Elijah Newren via GitGitGadget 2020-03-27 0:49 ` [PATCH v3 17/18] unpack-trees: failure to set SKIP_WORKTREE bits always just a warning Elijah Newren via GitGitGadget 2020-03-27 0:49 ` [PATCH v3 18/18] sparse-checkout: provide a new reapply subcommand Elijah Newren via GitGitGadget 2020-03-27 13:22 ` [PATCH v3 00/18] Sparse checkout improvements -- improved sparsity updating Derrick Stolee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABPp-BE=VdSAfAWR_2KivXbGOYknhJ=4sbRjVPAS+URNgjLFPQ@mail.gmail.com' \ --to=newren@gmail.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=stolee@gmail.com \ --subject='Re: [PATCH 7/7] sparse-checkout: provide a new update subcommand' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git