From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2D2C81F910 for ; Tue, 29 Nov 2022 05:11:37 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HAo/RB8p"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235097AbiK2FLb (ORCPT ); Tue, 29 Nov 2022 00:11:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232539AbiK2FLX (ORCPT ); Tue, 29 Nov 2022 00:11:23 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F38F94D5CA for ; Mon, 28 Nov 2022 21:11:21 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id c1so20749434lfi.7 for ; Mon, 28 Nov 2022 21:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x3Uqduv/YowPXLGKUNU0aJeRlwVpM4i7GIyhzTb5IK0=; b=HAo/RB8pu+PyJ+9RrRSKUfdLNIVoU0fN5hpbYe+a/1/Gx8015idLuGpilghWLD7a9/ wFmoFTUnVafRhVqyEVIhotMH0ZZheVJdXieI5zbjfA5xyEoI4FX9ZLEIOpwZo/7czifO FDKkDOkw4yQCsFB8IgVG2wlgFR2Ov1nfaIBbeMkjSqzQdxEx1gHDD1AbytsPaX99I9UC QJZNL2DRki8MdY1txausDoOjqqTJ77WFeDqa5eE4zSpubO/nDUDZtYqyqh/R2oEENyK1 H42c333PTlWZyf8i43+/Us1n/tOCGXZS01KeCqQqwyb+auT3olfSuhodEgJ/hC1zzAy0 rMBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x3Uqduv/YowPXLGKUNU0aJeRlwVpM4i7GIyhzTb5IK0=; b=y7A6xgSKyikz/pP/pJKwqtuDQ9INt4IU/yDxo4iHcxvPoKEbRaQZYmrN+ivu/SsVWU IbmJLOTZWTCleeO/CaQj1rYpGxL/aMcLLcGHf4DQml+W7QC7gYcy689Q7XN3UQZB9lUn 5sj5jrcjStvR2qLNLWDcy1/M1MMCOoyjVYUOZ+FQg8QfmTrcnMn/CzVIs6a6fJeIYQOK 4S8QdydC2ZR6nD1x0xau4wSYk7pa0zMp4zX/P/jPMLzbD4/9AbWIn/qX0fjC4pMPassK KS7oMIyBRwvf+aMFIoRO3qZ50FUtLU9r1PktfREy4qTO3gsvJy7klVwb14tzTbucBgXe A7WA== X-Gm-Message-State: ANoB5pl2nSURZ6ZdCbK8Jq2sawobe+E5kz/0ERrSMJ4uJrUCFeR0D8up VSdTB4jEHH/giC9S+63Yn5kzXU+kYlnr0iYi890= X-Google-Smtp-Source: AA0mqf7Yp+ofvR8sTdx4Qc+M3oWRVw4jajAb6JTsPzq0XOYzMGJpG3d1Jq8mqFqHlF+4aevtHZeOw4+2/+47wZVp2Tg= X-Received: by 2002:a05:6512:1681:b0:4a2:683d:3ba4 with SMTP id bu1-20020a056512168100b004a2683d3ba4mr21498441lfb.238.1669698680358; Mon, 28 Nov 2022 21:11:20 -0800 (PST) MIME-Version: 1.0 References: <20221108184200.2813458-2-calvinwan@google.com> In-Reply-To: <20221108184200.2813458-2-calvinwan@google.com> From: Elijah Newren Date: Mon, 28 Nov 2022 21:11:07 -0800 Message-ID: Subject: Re: [PATCH v4 1/5] run-command: add duplicate_output_fn to run_processes_parallel_opts To: Calvin Wan Cc: git@vger.kernel.org, emilyshaffer@google.com, avarab@gmail.com, phillip.wood123@gmail.com, myriamanis@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 8, 2022 at 11:11 AM Calvin Wan wrote: > > Add duplicate_output_fn as an optionally set function in > run_process_parallel_opts. If set, output from each child process is > copied and passed to the callback function whenever output from the > child process is buffered to allow for separate parsing. > > Signed-off-by: Calvin Wan [...] > diff --git a/t/helper/test-run-command.c b/t/helper/test-run-command.c > index 3ecb830f4a..40dd329e02 100644 > --- a/t/helper/test-run-command.c > +++ b/t/helper/test-run-command.c > @@ -52,6 +52,21 @@ static int no_job(struct child_process *cp, > return 0; > } > > +static void duplicate_output(struct strbuf *process_out, > + struct strbuf *out, > + void *pp_cb, > + void *pp_task_cb) Should the last two parameters have an "UNUSED" annotation?