* [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.
@ 2011-10-30 17:18 Dejan Ribič
2011-10-30 23:57 ` Erik Faye-Lund
0 siblings, 1 reply; 3+ messages in thread
From: Dejan Ribič @ 2011-10-30 17:18 UTC (permalink / raw
To: Git ML; +Cc: Dejan Ribič
"succeded" changed to "succeeded".
Reference Launchpad bug #879427.
modified: git-gui/lib/sshkey.tcl
Signed-off-by: Dejan Ribič <dejan.ribic@gmail.com>
---
git-gui/lib/sshkey.tcl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/sshkey.tcl b/git-gui/lib/sshkey.tcl
index 5f75bc9..aa6457b 100644
--- a/git-gui/lib/sshkey.tcl
+++ b/git-gui/lib/sshkey.tcl
@@ -117,7 +117,7 @@ proc read_sshkey_output {fd w} {
} else {
set finfo [find_ssh_key]
if {$finfo eq {}} {
- set sshkey_title [mc "Generation succeded, but no keys found."]
+ set sshkey_title [mc "Generation succeeded, but no keys found."]
$w.contents insert end $sshkey_output
} else {
set sshkey_title [mc "Your key is in: %s" [lindex $finfo 0]]
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.
2011-10-30 17:18 [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl Dejan Ribič
@ 2011-10-30 23:57 ` Erik Faye-Lund
2011-10-31 8:56 ` Pat Thoyts
0 siblings, 1 reply; 3+ messages in thread
From: Erik Faye-Lund @ 2011-10-30 23:57 UTC (permalink / raw
To: Dejan Ribič; +Cc: Git ML
Thanks for re-posting inline and with a sign-off. But there's still a
few minor nits:
2011/10/30 Dejan Ribič <dejan.ribic@gmail.com>:
> "succeded" changed to "succeeded".
We write commit messages in imperative mood, so this should be
something like 'change "succeded" to "succeeded"' instead. This is
documented in Documentation/SubmittingPatches.
> modified: git-gui/lib/sshkey.tcl
We don't normally include a list of changed files in the commit
message; the diffstat already provides that information.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.
2011-10-30 23:57 ` Erik Faye-Lund
@ 2011-10-31 8:56 ` Pat Thoyts
0 siblings, 0 replies; 3+ messages in thread
From: Pat Thoyts @ 2011-10-31 8:56 UTC (permalink / raw
To: kusmabite; +Cc: Dejan Ribič, Git ML
Erik Faye-Lund <kusmabite@gmail.com> writes:
>Thanks for re-posting inline and with a sign-off. But there's still a
>few minor nits:
>
>2011/10/30 Dejan Ribič <dejan.ribic@gmail.com>:
>> "succeded" changed to "succeeded".
>
>We write commit messages in imperative mood, so this should be
>something like 'change "succeded" to "succeeded"' instead. This is
>documented in Documentation/SubmittingPatches.
>
>> modified: git-gui/lib/sshkey.tcl
>
>We don't normally include a list of changed files in the commit
>message; the diffstat already provides that information.
>
The change is fine so I've applied this to the git-gui repository with a
fixed commit message. Thank you.
git-gui is hosted separately and merged into git-core at intervals so
the development version of git-gui is in fact hosted at
git://repo.or.cz/git-gui.git although patches against the git-core
version seldom pose a problem to apply and are gratefully received.
(git am -p2 usually fixes them).
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-31 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-30 17:18 [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl Dejan Ribič
2011-10-30 23:57 ` Erik Faye-Lund
2011-10-31 8:56 ` Pat Thoyts
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).