From: Erik Faye-Lund <kusmabite@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Dave Zarzycki <zarzycki@apple.com>, git@vger.kernel.org
Subject: Re: Resend: [PATCH] Do not log unless all connect() attempts fail
Date: Wed, 13 Jul 2011 11:26:35 +0200 [thread overview]
Message-ID: <CABPQNSYxQDxgDS5z-TMxC3WtNQ7KV_F4f6HTKOH-SpwMQsiHUw@mail.gmail.com> (raw)
In-Reply-To: <7v39iba3b2.fsf@alter.siamese.dyndns.org>
On Tue, Jul 12, 2011 at 6:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
> This looks Looks good to me; could you sign-off the patch, please?
>
As I noted on the resend with the sign-off, I believe there's a
problem with the patch where saved_errno is written to in one place
but the error never gets reported after applying the patch.
prev parent reply other threads:[~2011-07-13 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 18:06 Resend: [PATCH] Do not log unless all connect() attempts fail Dave Zarzycki
2011-07-12 5:55 ` Jeff King
2011-07-12 16:09 ` Junio C Hamano
2011-07-12 16:29 ` Dave Zarzycki
2011-07-13 9:26 ` Erik Faye-Lund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPQNSYxQDxgDS5z-TMxC3WtNQ7KV_F4f6HTKOH-SpwMQsiHUw@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zarzycki@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).