From: Robin Pedersen <robinp@snap.tv>
To: git@vger.kernel.org
Subject: Accidentially deleted directory, bug in git clean -d?
Date: Mon, 10 Mar 2014 11:31:37 +0100 [thread overview]
Message-ID: <CABN9-fcpyDogh45WPwuS1qgkE1jLuOAtejuW=fGCKNNyNm3DEQ@mail.gmail.com> (raw)
I accidentially deleted a directory using git clean. I would think
this is a bug, but I'm not sure. Was using 1.8.1, but upgraded to
1.9.0 just to see if it was still reproducable, and it was.
Here's a minimal way to reproduce:
$ git init
$ mkdir foo foobar
$ git clean -df foobar
Removing foo/
Removing foobar/
$ ls
$
I expected only "foobar" to be deleted, but "foo" was also deleted.
The same thing happens in the opposite case:
$ git init
$ mkdir foo foobar
$ git clean -df foo
Removing foo/
Removing foobar/
$ ls
$
However, it only happens when there is a common prefix in the names:
$ git init
$ mkdir foo bar
$ git clean -df foo
Removing foo/
$ ls
bar
$
In this case, "bar" was not deleted.
--
Best regards,
Robin Pedersen
Software Engineer
SnapTV AS
Jordmor Magdalenes vei 17
N-9519 Kviby.
Norway
robinp@snap.tv
http://www.snap.tv
next reply other threads:[~2014-03-10 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 10:31 Robin Pedersen [this message]
2014-03-10 17:20 ` [PATCH] clean: respect pathspecs with "-d" Jeff King
2014-03-10 17:22 ` Jeff King
2014-03-10 20:02 ` Simon Ruderich
2014-03-10 20:37 ` Jeff King
2014-03-10 17:24 ` [PATCH] clean: simplify dir/not-dir logic Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABN9-fcpyDogh45WPwuS1qgkE1jLuOAtejuW=fGCKNNyNm3DEQ@mail.gmail.com' \
--to=robinp@snap.tv \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).