Re: Git.pm

[Subho Banerjee <subs.zero@gmail.com>]

Hello,
I have started looking into how the error catching mechanism
implemented right now. I have looked into the more modern error
catching/throwing mechanisms in use in perl, and I am of the opinion
that Try::Simple would probably be the best candidate for being the
new error catching mechanism. I also wanted to discuss some aspects of
the changes to be made -
------- Replacing the Error::Simple stuff should be relatively
straightforward. It can be achieved with simple changes to the syntax
of the perl module itself.

------- What I feel will be more complicated, and will require some
discussion before it is implemented is the Git::Error module. This has
modified some of the code in the original Error module and is used
only when there are calls made to the git system command. Using the
Try::Tiny will mean that this can be simplfied to a very large extent.
As a mater of fact I am in favor of getting rid of this completely and
implementing whatever is required in the Git.pm as required. Because
the Try::Tiny module no longer requires exception objects to be
thrown. Its just simply passing strings around.

This I believe is a big decision, and I would like to hear what you
guys have to say before I actually get along changing and playing
around with stuff inside the code.

Cheers,
Subho.

On Fri, Apr 27, 2012 at 2:01 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi,
>
> Subho Banerjee wrote:
>
>> I will take care that I dont break those.
>
> Thanks, sounds good.
>
>>                                           Should the tests in the t/
>> folder of the codebase be enough to make sure everything is working as
>> it should be even in the Git perl module?
>
> No. :)
>
>>                                           Also is there anything like
>> a public build server which actually catalogs which tests are
>> currently failing so that I know what has gone wrong after my changes,
>> or are all commits supposed to pass every test?
>
> When tests are known to fail, they are marked with test_expect_failure
> so they don't affect the test result.
>
> Hope that helps,
> Jonathan