git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Simon Gerber <gesimu@gmail.com>
To: Simon Gerber via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] help.c: fix autocorrect in work tree for bare repository
Date: Mon, 12 Dec 2022 17:38:54 +0100	[thread overview]
Message-ID: <CAAyHH30eoRAgtO+QOZZFbx89Nr55xtndu6pRa5k=ZnJZXnZACw@mail.gmail.com> (raw)
In-Reply-To: <pull.1373.v2.git.git.1667073374852.gitgitgadget@gmail.com>

On Sat, 29 Oct 2022 at 21:56, Simon Gerber via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> [commit message omitted]
> ---
>     Fix autocorrect in work tree for bare repository
>
>     Currently, auto correction doesn't work reliably for commands which must
>     run in a work tree (e.g. git status) in Git work trees which are created
>     from a bare repository.
>
>     This patch adds a test case illustrating the issue and proposes a fix
>     which adjusts the usage of read_early_config() in help_unknown_cmd() to
>     match other usages of read_early_config(). In particular the patch
>     removes the call to git_default_config() in the read config callback.
>
>     Changes since v1 (both suggested by Junio):
>
>      * Moved test to 9003
>      * Squashed change and test into a single commit
>
> [diff omitted]

Hi all,

Just wanted to check what the state on this patch is (side-note: I
just noticed that I didn't cc Junio in the v2 submission, my
apologies). As described in the quote (and the parent email), the
patch fixes how auto correct initializes the config. Version 2
addresses the points raised on v1, in particular, I've moved the test
to 9003, and have squashed the change into a single commit. Please let
me know if further changes are necessary.

-- Simon

  reply	other threads:[~2022-12-12 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 15:24 [PATCH 0/2] Fix autocorrect in work tree for bare repository Simon Gerber via GitGitGadget
2022-10-28 15:24 ` [PATCH 1/2] tests: add test case for autocorrect in work tree for bare clone Simon Gerber via GitGitGadget
2022-10-28 19:28   ` Junio C Hamano
2022-10-29  8:07     ` Simon Gerber
2022-10-28 15:24 ` [PATCH 2/2] help.c: don't call git_default_config in git_unknown_cmd_config Simon Gerber via GitGitGadget
2022-10-29 19:56 ` [PATCH v2] help.c: fix autocorrect in work tree for bare repository Simon Gerber via GitGitGadget
2022-12-12 16:38   ` Simon Gerber [this message]
2022-12-13  1:37   ` Junio C Hamano
2022-12-13  9:48     ` Simon Gerber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAyHH30eoRAgtO+QOZZFbx89Nr55xtndu6pRa5k=ZnJZXnZACw@mail.gmail.com' \
    --to=gesimu@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).