From: Gopal Yadav <gopunop@gmail.com>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, sunshine@sunshineco.com
Subject: Re: [NEW] Git
Date: Wed, 19 Aug 2020 12:48:17 +0530 [thread overview]
Message-ID: <CAAUOv8jraMz3+M_fddwAVcLNGPZehgosvHXyCSUx1u+555LmOA@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRF=PXWTgOzxAsMQ=bSUPnsORBKWUTk38BCvMSVzS=KJw@mail.gmail.com>
On Tue, Aug 18, 2020 at 10:22 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Tue, Aug 18, 2020 at 8:23 AM Gopal Yadav <gopunop@gmail.com> wrote:
> No. test_lazy_prereq() is merely the function which defines how a lazy
> prerequisites should be determined when the answer about the
> prerequisite is actually needed. What #353 is saying is to not perform
> the actual determination if a test which requires it isn't going to be
> run.
>
> Fixing the issue might be as simple as moving the test_verify_prereq()
> call (and related "export") inside the 'if ! test_skip "$@"'
> conditional in the test_expect_success() and test_expect_failure()
> functions.
I see that test_verify_prereq() (and related export) being used inside
3 different functions
namely test_expect_failure(), test_expect_success() and test_external().
So the solution here is to move these into the if ! test_skip block.
Thanks, will submit a patch.
> > I know the issue talks about something related to chains but I am
> > thinking of starting by resolving the lazy prereq task first.
>
> I took a look at the &&-chain logic and, as far as I can tell by both
> direct inspection and by experimentation, the detection of broken
> &&-chains is _not_ performed for tests which are being skipped. So, I
> think that portion of #353 is just wrong.
prev parent reply other threads:[~2020-08-19 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:23 [NEW] Git Gopal Yadav
2020-08-18 16:52 ` Eric Sunshine
2020-08-19 7:18 ` Gopal Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAUOv8jraMz3+M_fddwAVcLNGPZehgosvHXyCSUx1u+555LmOA@mail.gmail.com \
--to=gopunop@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).