From: Ariadne Conill <ariadne@dereferenced.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
Ariadne Conill <ariadne@dereferenced.org>,
git@vger.kernel.org
Subject: Re: [PATCH] log: use mailmap by default
Date: Thu, 11 Jul 2019 11:25:32 -0500 [thread overview]
Message-ID: <CAAOiGNzXreYk9xoVOFkcivrXK4QkH495T7Lq76j3oz593rSzDQ@mail.gmail.com> (raw)
In-Reply-To: <20190711151900.GI9224@genre.crustytoothpaste.net>
Hello,
On Thu, Jul 11, 2019 at 10:19 AM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On 2019-07-11 at 08:19:58, Ariadne Conill wrote:
> > The `git log` command shows the author and committer name recorded in
> > the git repository itself, while other commands respect `.mailmap`
> > by default. I believe this is a bad design: it causes log entries to
> > reflect inaccurate information: anyone who changes their name or
> > e-mail address will not have that change (recorded in mailmap file)
> > reflected when using `git log` by default.
> >
> > Anyone who explicitly wants the current behaviour can clearly request
> > it by setting the `log.mailmap` setting to `false` in their
> > `.gitconfig` file.
>
> While I'm in favor of using the mailmap by default, typically we want a
> way people can override a default setting from the command line.
>
> So in this case, we have "--use-mailmap", but we don't have a
> "--no-use-mailmap" (at least, it's not documented in the manpage). I
> think we'd want to add such an option so that people can set it if they
> need non-default behavior.
I agree that there is probably some useful reasons to have this
option, so I can add an option that forces mailmap usage off to
supplement the --use-mailmap option. It's no problem. I will
generate a new patch series in a few minutes.
Thanks for reviewing!
Ariadne
next prev parent reply other threads:[~2019-07-11 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 8:19 [PATCH] log: use mailmap by default Ariadne Conill
2019-07-11 15:19 ` brian m. carlson
2019-07-11 16:25 ` Ariadne Conill [this message]
2019-07-11 17:09 ` Martin Ågren
2019-07-11 17:42 ` Ariadne Conill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAOiGNzXreYk9xoVOFkcivrXK4QkH495T7Lq76j3oz593rSzDQ@mail.gmail.com \
--to=ariadne@dereferenced.org \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).