From: Thadeus Fleming <thadeus.j.fleming@gmail.com>
To: git@vger.kernel.org
Subject: git submodule add fails when using both --branch and --depth
Date: Sat, 30 Sep 2017 12:20:50 -0500 [thread overview]
Message-ID: <CAA4Wa2sVddG_SS70Dy_womGLKW0ipAjsxR4g+yjMKscjErRjvQ@mail.gmail.com> (raw)
I'm running git 2.14.2 on Ubuntu 16.04.
Compare the behavior of
> git clone --branch pu --depth 1 https://github.com/git/git git-pu
which clones only the latest commit of the pu branch and
> mkdir tmp && cd tmp && git init
> git submodule add --branch pu --depth 1 https://github.com/git/git \
git-pu
which gives the error
fatal: 'origin/pu' is not a commit and a branch 'pu' cannot be created
from it
Unable to checkout submodule 'git-pu'
Investigating further, there is indeed only one commit in the local repo:
> cd git-pu
> git log --oneline | wc -l
1
But that commit is the head of master.
> git branch -a
* master remotes/origin/master
remotes/origin/HEAD -> origin/master
This appears to be because git-submodule--helper does not accept a
--branch option. Using the --depth N option causes it to only clone N
commits from the default branch, which generally do not include the
desired branch. Thus, the next step,
git checkout -f -q -B "$branch" "origin/$branch"
fails, and provides the rather confusing error message above.
I'd suggest that git-submodule--helper learn a --branch option
consistent with git clone, and if that is impossible, that
git submodule add rejects the simultaneous use of both the --branch and
--depth options.
--tjf
next reply other threads:[~2017-09-30 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 17:20 Thadeus Fleming [this message]
2017-10-02 19:55 ` git submodule add fails when using both --branch and --depth Stefan Beller
2017-10-02 22:08 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4Wa2sVddG_SS70Dy_womGLKW0ipAjsxR4g+yjMKscjErRjvQ@mail.gmail.com \
--to=thadeus.j.fleming@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).