From: Eric Rannaud <eric.rannaud@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeremy Serror <jeremy.serror@gmail.com>,
Brandon Williams <bmwill@google.com>
Subject: Re: git rebase regression: cannot pass a shell expression directly to --exec
Date: Tue, 16 May 2017 10:11:05 -0700 [thread overview]
Message-ID: <CA+zRj8VjNDaX0vgWX5pRMMVnFHzb_Hgx-WhHgVEe74JaRawO0g@mail.gmail.com> (raw)
In-Reply-To: <20170516164750.3tw6xlbcbyuu5t72@sigill.intra.peff.net>
On Tue, May 16, 2017 at 9:47 AM, Jeff King <peff@peff.net> wrote:
>> I think we want to behave consistently for shell builtins and for
>> exported functions --- they are different sides of the same problem,
>> and behaving differently between the two feels confusing.
>
> Yes, I think ideally we'd handle it all transparently. Although I'd also
> point out that Git the behavior under discussion dates back to 2009 and
> this is (as far as I can recall) the first report. So documenting the
> current behavior might not be that bad an option.
This is on Arch Linux which is usually pretty aggressive with their
Git upgrades and I first saw the problem this week. The script that
hits this case runs constantly on my machine so my guess is that if
anyone relies on the old behavior, they're just starting to see a
new-enough Git to have a problem.
next prev parent reply other threads:[~2017-05-16 17:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 18:08 git rebase regression: cannot pass a shell expression directly to --exec Eric Rannaud
2017-05-16 3:25 ` Jeff King
2017-05-16 3:37 ` Jeff King
2017-05-16 16:41 ` Jonathan Nieder
2017-05-16 16:47 ` Jeff King
2017-05-16 17:11 ` Eric Rannaud [this message]
2017-05-16 17:15 ` Brandon Williams
2017-05-16 17:23 ` Jeff King
2017-05-16 17:30 ` Brandon Williams
2017-05-16 19:14 ` Linus Torvalds
2017-05-16 19:35 ` [TANGENT] run-command: use vfork instead of fork Eric Wong
2017-05-16 20:47 ` Linus Torvalds
2017-05-16 21:11 ` Brandon Williams
2017-05-16 20:12 ` git rebase regression: cannot pass a shell expression directly to --exec Johannes Schindelin
2017-05-16 20:27 ` Linus Torvalds
2017-05-16 17:37 ` Jonathan Nieder
2017-05-16 3:40 ` Junio C Hamano
2017-05-16 3:53 ` Jeff King
2017-05-16 4:08 ` Jeff King
2017-05-16 16:45 ` Eric Rannaud
2017-05-16 10:46 ` Johannes Schindelin
2017-05-16 10:23 ` Johannes Schindelin
2017-05-16 16:18 ` Jeff King
2017-05-16 16:59 ` Eric Rannaud
2017-05-16 17:14 ` Kevin Daudt
2017-05-16 17:29 ` Eric Rannaud
2017-05-16 17:41 ` Jeff King
2017-05-16 17:21 ` Eric Rannaud
2017-05-16 17:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+zRj8VjNDaX0vgWX5pRMMVnFHzb_Hgx-WhHgVEe74JaRawO0g@mail.gmail.com \
--to=eric.rannaud@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jeremy.serror@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).