From: Eric Rannaud <eric.rannaud@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeremy Serror <jeremy.serror@gmail.com>
Subject: Re: git rebase regression: cannot pass a shell expression directly to --exec
Date: Tue, 16 May 2017 09:45:38 -0700 [thread overview]
Message-ID: <CA+zRj8V94H4E1DPage1-YAVGAxHC_8oYiSoFrwHkg0QbUsJu0Q@mail.gmail.com> (raw)
In-Reply-To: <20170516035357.2wutcd2tyax4tjyn@sigill.intra.peff.net>
On Mon, May 15, 2017 at 8:53 PM, Jeff King <peff@peff.net> wrote:
>> > So I suspect if you added an extraneous semi-colon, your case would work
>> > again (and that would confirm for us that this is indeed the problem).
>>
>> Wow, that's a brilliant analysis.
>
> If it's right. :) It's all theory at this point.
>
> My /bin/sh isn't bash, but I should be able to build with
> SHELL_PATH=/bin/bash to reproduce. But I can't:
Just to clarify if there was any doubt, the semicolon trick does
indeed work fine when bash is your shell.
It would be nice if it were consistent for all git commands that take
a <cmd> argument:
foo() { echo foo; }
export -f foo
git bisect start master master^^
git bisect run foo # works
git bisect run 'foo;' # doesn't work
running foo;
/usr/lib/git-core/git-bisect: line 493: foo;: command not found
Also, what's a "simple command", exactly?
foo() { echo foo; }
export -f foo
git rebase --exec foo master^^ # fails
git rebase --exec 'foo;' master^^ # OK
git rebase --exec 'foo 1' master^^ # OK
Not sure if this can be made easy to understand in the manpage.
Thanks,
Eric
next prev parent reply other threads:[~2017-05-16 16:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 18:08 git rebase regression: cannot pass a shell expression directly to --exec Eric Rannaud
2017-05-16 3:25 ` Jeff King
2017-05-16 3:37 ` Jeff King
2017-05-16 16:41 ` Jonathan Nieder
2017-05-16 16:47 ` Jeff King
2017-05-16 17:11 ` Eric Rannaud
2017-05-16 17:15 ` Brandon Williams
2017-05-16 17:23 ` Jeff King
2017-05-16 17:30 ` Brandon Williams
2017-05-16 19:14 ` Linus Torvalds
2017-05-16 19:35 ` [TANGENT] run-command: use vfork instead of fork Eric Wong
2017-05-16 20:47 ` Linus Torvalds
2017-05-16 21:11 ` Brandon Williams
2017-05-16 20:12 ` git rebase regression: cannot pass a shell expression directly to --exec Johannes Schindelin
2017-05-16 20:27 ` Linus Torvalds
2017-05-16 17:37 ` Jonathan Nieder
2017-05-16 3:40 ` Junio C Hamano
2017-05-16 3:53 ` Jeff King
2017-05-16 4:08 ` Jeff King
2017-05-16 16:45 ` Eric Rannaud [this message]
2017-05-16 10:46 ` Johannes Schindelin
2017-05-16 10:23 ` Johannes Schindelin
2017-05-16 16:18 ` Jeff King
2017-05-16 16:59 ` Eric Rannaud
2017-05-16 17:14 ` Kevin Daudt
2017-05-16 17:29 ` Eric Rannaud
2017-05-16 17:41 ` Jeff King
2017-05-16 17:21 ` Eric Rannaud
2017-05-16 17:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+zRj8V94H4E1DPage1-YAVGAxHC_8oYiSoFrwHkg0QbUsJu0Q@mail.gmail.com \
--to=eric.rannaud@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeremy.serror@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).