From: Sebastian Staudt <koraktor@gmail.com>
To: gitster@pobox.com
Cc: larsxschneider@gmail.com, szeder.dev@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] travis-ci: no longer use containers
Date: Fri, 26 Oct 2018 07:06:18 +0200 [thread overview]
Message-ID: <CA+xP2Sbm7YGU3tKMNEzrvZfOQScgE2-ap1GVCXcjLH5botr4ug@mail.gmail.com> (raw)
In-Reply-To: <xmqqo9bhfu0j.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
>
> Sebastian Staudt <koraktor@gmail.com> writes:
>
> > Travis CI will soon deprecate the container-based infrastructure
> > enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753.
> >
> > More info:
> > https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures
>
> Thanks for posting a patch that would serve as a good discussion
> starter. This is not a criticism on your patch, but more is a RFD
> to those who helped our use of Travis by contributing to .travis.yml
> and ci/.
In fact this was the intention while creating this patch. Although I see
I could have made this a bit clearer in the initial message.
Having a patch that may cause a broken build or other CI problems
seems more appropriate than waiting for Travis CI to flip the switch
and searching for the problem afterwards.
> Don't we need to do some other things so that we can run in vm
> environment, rather than in container environment, before doing this
> change? IOW, aren't we doing in .travis.yml something we can do
> only in container but not in vm (if there is any), and if so,
> shouldn't we be rewriting that something so that we can run in vm?
>
> I know ce59dffb ("travis-ci: explicity use container-based
> infrastructure", 2016-01-26) only added "sudo: false" without doing
> anything else (e.g. adding things that are only available to those
> who run in container), but if we added stuff that are not usable in
> vm environment after that commit since then, we need to adjust them
> so that we can migrate to the container-based environment, no?
>
> To me, removing that "sudo: false" line seems like the least thing
> we need to worry about. After all, they say that whether we have
> "sudo: false" or not, the CI jobs will start running in vm
> environment and not in container. So if the rest of .travis.yml is
> ready to run in vm environment, we do not have to do anything ;-).
>
> In short, my question to Lars and SZEDER is, are we already prepared
> to be thrown into a vm environment?
>
> If the answer is "yes", then I think removing "sudo: false" is
> probably still a good thing to do for documentation purposes
> (i.e. showing that we knew we are ready to go through their
> migration).
>
> Thanks.
>
> > Signed-off-by: Sebastian Staudt <koraktor@gmail.com>
> > ---
> > .travis.yml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 4d4e26c9df..8d2499739e 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -1,7 +1,5 @@
> > language: c
> >
> > -sudo: false
> > -
> > cache:
> > directories:
> > - $HOME/travis-cache
> > --
> > 2.19.1
prev parent reply other threads:[~2018-10-26 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 17:41 [PATCH] travis-ci: no longer use containers Sebastian Staudt
2018-10-26 0:09 ` Junio C Hamano
2018-10-26 1:39 ` SZEDER Gábor
2018-11-01 11:47 ` [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' SZEDER Gábor
2018-11-02 2:25 ` Junio C Hamano
2018-11-08 21:51 ` SZEDER Gábor
2018-11-09 2:59 ` Junio C Hamano
2018-11-09 12:08 ` Johannes Schindelin
2018-10-26 5:06 ` Sebastian Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+xP2Sbm7YGU3tKMNEzrvZfOQScgE2-ap1GVCXcjLH5botr4ug@mail.gmail.com \
--to=koraktor@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).