From: Jacob Keller <jacob.keller@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Jeff King <peff@peff.net>, Git mailing list <git@vger.kernel.org>
Subject: Re: git commit file completion recently broke
Date: Thu, 7 Dec 2017 10:57:23 -0800 [thread overview]
Message-ID: <CA+P7+xrhgbcogxYa38jEu3PuF5hVNNYPjAq031bYE8bgao168Q@mail.gmail.com> (raw)
In-Reply-To: <xmqq8teeftn7.fsf@gitster.mtv.corp.google.com>
On Thu, Dec 7, 2017 at 7:24 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Christian Couder <christian.couder@gmail.com> writes:
>
>>> I do think it may make sense for
>>> the "short" one to use NULL, like:
>>>
>>> skip_to_optional_val(arg, "--relative, &arg)
>>>
>>> but maybe some other callers would be more inconvenienced (they may have
>>> to current NULL back into the empty string if they want to string
>>> "--foo" the same as "--foo=").
>>
>> I discussed that with Junio and yeah there are many callers that want
>> "--foo" to be the same as "--foo=".
>
> Yup, the original thread has details and me saying that assuming all
> of them want --foo and --foo= the same is questionable. The likely
> fix would be to use the _default variant with NULL, which was added
> exactly for cases like this.
>
Slightly more complex. You have to use the _default variant, pass in
arg instead of options->prefix, and then make sure arg was set before
overwriting options->prefix. If you just use _default with NULL, it
will not quite fix the problem.
Thanks,
Jake
prev parent reply other threads:[~2017-12-07 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 23:53 git commit file completion recently broke Jacob Keller
2017-12-07 0:01 ` Jacob Keller
2017-12-07 0:08 ` Jacob Keller
2017-12-07 0:22 ` Jeff King
2017-12-07 0:24 ` Jeff King
2017-12-07 0:38 ` Jacob Keller
2017-12-07 0:56 ` Jeff King
2017-12-07 1:04 ` Jacob Keller
2017-12-07 1:08 ` Jeff King
2017-12-07 8:14 ` Christian Couder
2017-12-07 8:19 ` Jeff King
2017-12-07 15:24 ` Junio C Hamano
2017-12-07 18:57 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+P7+xrhgbcogxYa38jEu3PuF5hVNNYPjAq031bYE8bgao168Q@mail.gmail.com \
--to=jacob.keller@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).