git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] gitk: Add a "Copy commit summary" command
@ 2015-07-14 16:42 dev+git
  2015-07-14 20:34 ` Stefan Beller
  0 siblings, 1 reply; 5+ messages in thread
From: dev+git @ 2015-07-14 16:42 UTC (permalink / raw)
  To: git; +Cc: Beat Bolli, Paul Mackerras

From: Beat Bolli <dev+git@drbeat.li>

When referencing earlier commits in new commit messages or other text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)

Add a "Copy commit summary" command to the context menu that puts this
text for the currently selected commit on the clipboard. This makes it
easy for our users to create well-formatted commit references.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Cc: Paul Mackerras <paulus@samba.org>
---
 gitk-git/gitk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..0612331 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
 	{mc "Diff selected -> this" command {diffvssel 1}}
 	{mc "Make patch" command mkpatch}
 	{mc "Create tag" command mktag}
+	{mc "Copy commit summary" command copysummary}
 	{mc "Write commit to file" command writecommit}
 	{mc "Create new branch" command mkbranch}
 	{mc "Cherry-pick this commit" command cherrypick}
@@ -9341,6 +9342,19 @@ proc mktaggo {} {
     mktagcan
 }
 
+proc copysummary {} {
+    global rowmenuid commitinfo
+
+    set id [string range $rowmenuid 0 7]
+    set info $commitinfo($rowmenuid)
+    set commit [lindex $info 0]
+    set date [formatdate [lindex $info 2]]
+    set summary "[mc "commit"] $id (\"$commit\", $date)"
+
+    clipboard clear
+    clipboard append $summary
+}
+
 proc writecommit {} {
     global rowmenuid wrcomtop commitinfo wrcomcmd NS
 
-- 
2.1.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gitk: Add a "Copy commit summary" command
  2015-07-14 16:42 [PATCH] gitk: Add a "Copy commit summary" command dev+git
@ 2015-07-14 20:34 ` Stefan Beller
  2015-07-15 22:24   ` Keller, Jacob E
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Beller @ 2015-07-14 20:34 UTC (permalink / raw)
  To: dev+git; +Cc: git, Paul Mackerras

On Tue, Jul 14, 2015 at 9:42 AM,  <dev+git@drbeat.li> wrote:
> From: Beat Bolli <dev+git@drbeat.li>
>
> When referencing earlier commits in new commit messages or other text,
> one of the established formats is
>
>     commit <abbrev-sha> ("<summary>", <author-date>)

That sounds like I would use it a lot! Thanks :)

>
> Add a "Copy commit summary" command to the context menu that puts this
> text for the currently selected commit on the clipboard. This makes it
> easy for our users to create well-formatted commit references.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> Cc: Paul Mackerras <paulus@samba.org>
> ---
>  gitk-git/gitk | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 9a2daf3..0612331 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2617,6 +2617,7 @@ proc makewindow {} {
>         {mc "Diff selected -> this" command {diffvssel 1}}
>         {mc "Make patch" command mkpatch}
>         {mc "Create tag" command mktag}
> +       {mc "Copy commit summary" command copysummary}
>         {mc "Write commit to file" command writecommit}
>         {mc "Create new branch" command mkbranch}
>         {mc "Cherry-pick this commit" command cherrypick}
> @@ -9341,6 +9342,19 @@ proc mktaggo {} {
>      mktagcan
>  }
>
> +proc copysummary {} {
> +    global rowmenuid commitinfo
> +
> +    set id [string range $rowmenuid 0 7]
> +    set info $commitinfo($rowmenuid)
> +    set commit [lindex $info 0]
> +    set date [formatdate [lindex $info 2]]
> +    set summary "[mc "commit"] $id (\"$commit\", $date)"
> +
> +    clipboard clear
> +    clipboard append $summary
> +}
> +
>  proc writecommit {} {
>      global rowmenuid wrcomtop commitinfo wrcomcmd NS
>
> --
> 2.1.4
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gitk: Add a "Copy commit summary" command
  2015-07-14 20:34 ` Stefan Beller
@ 2015-07-15 22:24   ` Keller, Jacob E
  2015-07-15 23:58     ` Eric Sunshine
  0 siblings, 1 reply; 5+ messages in thread
From: Keller, Jacob E @ 2015-07-15 22:24 UTC (permalink / raw)
  To: sbeller, dev+git; +Cc: git, paulus

On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
> On Tue, Jul 14, 2015 at 9:42 AM,  <dev+git@drbeat.li> wrote:
> > From: Beat Bolli <dev+git@drbeat.li>
> > 
> > When referencing earlier commits in new commit messages or other 
> > text,
> > one of the established formats is
> > 
> >     commit <abbrev-sha> ("<summary>", <author-date>)
> 
> That sounds like I would use it a lot! Thanks :)
> 

Yep, quite useful. Also, the kernel suggests using it as a tag like so

Fixes: <abbrev-sha> ("summary")

I really like this :)

Regards,
Jake

> > 
> > Add a "Copy commit summary" command to the context menu that puts 
> > this
> > text for the currently selected commit on the clipboard. This makes 
> > it
> > easy for our users to create well-formatted commit references.
> > 
> > Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> > Cc: Paul Mackerras <paulus@samba.org>
> > ---
> >  gitk-git/gitk | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/gitk-git/gitk b/gitk-git/gitk
> > index 9a2daf3..0612331 100755
> > --- a/gitk-git/gitk
> > +++ b/gitk-git/gitk
> > @@ -2617,6 +2617,7 @@ proc makewindow {} {
> >         {mc "Diff selected -> this" command {diffvssel 1}}
> >         {mc "Make patch" command mkpatch}
> >         {mc "Create tag" command mktag}
> > +       {mc "Copy commit summary" command copysummary}
> >         {mc "Write commit to file" command writecommit}
> >         {mc "Create new branch" command mkbranch}
> >         {mc "Cherry-pick this commit" command cherrypick}
> > @@ -9341,6 +9342,19 @@ proc mktaggo {} {
> >      mktagcan
> >  }
> > 
> > +proc copysummary {} {
> > +    global rowmenuid commitinfo
> > +
> > +    set id [string range $rowmenuid 0 7]
> > +    set info $commitinfo($rowmenuid)
> > +    set commit [lindex $info 0]
> > +    set date [formatdate [lindex $info 2]]
> > +    set summary "[mc "commit"] $id (\"$commit\", $date)"
> > +
> > +    clipboard clear
> > +    clipboard append $summary
> > +}
> > +
> >  proc writecommit {} {
> >      global rowmenuid wrcomtop commitinfo wrcomcmd NS
> > 
> > --
> > 2.1.4
> > --
> > To unsubscribe from this list: send the line "unsubscribe git" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gitk: Add a "Copy commit summary" command
  2015-07-15 22:24   ` Keller, Jacob E
@ 2015-07-15 23:58     ` Eric Sunshine
  2015-07-16  0:59       ` Jacob Keller
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Sunshine @ 2015-07-15 23:58 UTC (permalink / raw)
  To: Keller, Jacob E; +Cc: sbeller, dev+git, git, paulus

On Wed, Jul 15, 2015 at 6:24 PM, Keller, Jacob E
<jacob.e.keller@intel.com> wrote:
> On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
>> On Tue, Jul 14, 2015 at 9:42 AM,  <dev+git@drbeat.li> wrote:
>> > From: Beat Bolli <dev+git@drbeat.li>
>> >
>> > When referencing earlier commits in new commit messages or other
>> > text,
>> > one of the established formats is
>> >
>> >     commit <abbrev-sha> ("<summary>", <author-date>)
>>
>> That sounds like I would use it a lot! Thanks :)
>>
>
> Yep, quite useful. Also, the kernel suggests using it as a tag like so
>
> Fixes: <abbrev-sha> ("summary")

Dropping the literal word "commit" would make this use-case more
convenient, as well as the typical use-case when composing commit
messages: "Since <abrrev-sha1> ("blah", <date>), foobar.c has
flabble-nabbered the wonka-doodle..."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gitk: Add a "Copy commit summary" command
  2015-07-15 23:58     ` Eric Sunshine
@ 2015-07-16  0:59       ` Jacob Keller
  0 siblings, 0 replies; 5+ messages in thread
From: Jacob Keller @ 2015-07-16  0:59 UTC (permalink / raw)
  To: Eric Sunshine; +Cc: Keller, Jacob E, sbeller, dev+git, git, paulus

Agreed. I haven't seen "commit" used much in the past, and you can
easily type that out as it is.

On Wed, Jul 15, 2015 at 4:58 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Wed, Jul 15, 2015 at 6:24 PM, Keller, Jacob E
> <jacob.e.keller@intel.com> wrote:
>> On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
>>> On Tue, Jul 14, 2015 at 9:42 AM,  <dev+git@drbeat.li> wrote:
>>> > From: Beat Bolli <dev+git@drbeat.li>
>>> >
>>> > When referencing earlier commits in new commit messages or other
>>> > text,
>>> > one of the established formats is
>>> >
>>> >     commit <abbrev-sha> ("<summary>", <author-date>)
>>>
>>> That sounds like I would use it a lot! Thanks :)
>>>
>>
>> Yep, quite useful. Also, the kernel suggests using it as a tag like so
>>
>> Fixes: <abbrev-sha> ("summary")
>
> Dropping the literal word "commit" would make this use-case more
> convenient, as well as the typical use-case when composing commit
> messages: "Since <abrrev-sha1> ("blah", <date>), foobar.c has
> flabble-nabbered the wonka-doodle..."
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-07-16  1:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 16:42 [PATCH] gitk: Add a "Copy commit summary" command dev+git
2015-07-14 20:34 ` Stefan Beller
2015-07-15 22:24   ` Keller, Jacob E
2015-07-15 23:58     ` Eric Sunshine
2015-07-16  0:59       ` Jacob Keller

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).