From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Keller Subject: Re: [RFC/PATCH 07/11] branch: move 'current' check down to the presentation layer Date: Tue, 28 Jul 2015 17:46:51 -0700 Message-ID: References: <1438066594-5620-1-git-send-email-Karthik.188@gmail.com> <1438066594-5620-7-git-send-email-Karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Matthieu Moy , Git , Christian Couder , Junio C Hamano To: Karthik Nayak X-From: git-owner@vger.kernel.org Wed Jul 29 02:47:17 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZKFWf-0000q2-Aa for gcvg-git-2@plane.gmane.org; Wed, 29 Jul 2015 02:47:17 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbbG2ArM (ORCPT ); Tue, 28 Jul 2015 20:47:12 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:38161 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbbG2ArM (ORCPT ); Tue, 28 Jul 2015 20:47:12 -0400 Received: by iggf3 with SMTP id f3so2671363igg.1 for ; Tue, 28 Jul 2015 17:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=XZ6aSaBbiOngkshjjJLLddMt56f6xMR+8wkw2OQJFO4=; b=EytTkUouP8tSiwS66X/iVW/CkR3wGpBmELVimTMcqAT5Eur1aid4CQW9KgdKP28lSl ZebU0ErdfQoVb+MPo79EptQcbz+mwbASVGfYAxBaZ+Qd7HzHlnHktbhouTA+zYiPdWlQ EXcbB47qV2XYOAJ1fOUnWJ9WwW9/undP9/+2CwKizuS7wNl0DEeQRJB8VdtHDfxMTfzm 4ghxPFTV3rQBgtmFDLgJp7Y3hY5YiIO7/Yl6w4GOpLp6FxiuUXUBt+mG3ElatmuIPFbA K/eyJuRJ9R603VLR6jOelhRYE/EfqBqlpumP9TUCW6qPg6Vp7fRLTac8Qtt7co2HVJa+ roeQ== X-Received: by 10.50.61.179 with SMTP id q19mr421073igr.24.1438130831326; Tue, 28 Jul 2015 17:47:11 -0700 (PDT) Received: by 10.107.5.203 with HTTP; Tue, 28 Jul 2015 17:46:51 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Jul 28, 2015 at 1:12 PM, Karthik Nayak wrote: > On Tue, Jul 28, 2015 at 6:39 PM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> We check if given ref is the current branch in print_ref_list(). Move >>> this check to print_ref_item() where it is checked right before >>> printing. >> >> This means that the '*' and the different color are coded in C, hence >> it's not possible to mimick this using "git for-each-ref --format ...". >> >> I do not consider this as blocking, but I think the ultimate goal should >> be to allow this, so that all the goodies of "git branch" can be made >> available to other ref-listing commands. >> > > Not sure what you mean here. > He means to make sure that any feature that was in tag, branch, for-each-ref, etc should be available as part of ref-filter and in all of them Maybe he misunderstood code or maybe you misunderstood the comment here? Regards, Jake