mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jacob Keller <>
To: Jeff King <>
Cc: Jacob Keller <>,
	Git mailing list <>,
	Junio C Hamano <>,
	Christian Couder <>
Subject: Re: [PATCH] diff: add tests for --relative without optional prefix value
Date: Thu, 7 Dec 2017 13:20:23 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Dec 7, 2017 at 1:12 PM, Jeff King <> wrote:
> On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:
>> From: Jacob Keller <>
>> We already have tests for --relative, but they currently only test when
>> a prefix has been provided. This fails to test the case where --relative
>> by itself should use the current directory as the prefix.
>> Teach the check_$type functions to take a directory argument to indicate
>> which subdirectory to run the git commands in. Add a new test which uses
>> this to test --relative without a prefix value.
> This looks good to me (and I slightly prefer it over Junio's for the
> simplicity).
> I agree on the ordering suggestion Junio made.
> -Peff

As do I. Junio, if we go with my version, feel free to squash in the
re-order. Or if you prefer, I can send a v2 (though for such a small
change I don't see the benefit).


  reply	other threads:[~2017-12-07 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 19:01 [PATCH] diff: add tests for --relative without optional prefix value Jacob Keller
2017-12-07 19:17 ` Junio C Hamano
2017-12-07 19:54   ` Jacob Keller
2017-12-07 21:12 ` Jeff King
2017-12-07 21:20   ` Jacob Keller [this message]
2017-12-07 21:50   ` Junio C Hamano
2017-12-07 22:05     ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).