From: Jacob Keller <jacob.keller@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jakub Narębski" <jnareb@gmail.com>,
"Christian Neukirchen" <chneukirchen@gmail.com>,
"Git mailing list" <git@vger.kernel.org>
Subject: Re: git commit -p with file arguments
Date: Sun, 11 Sep 2016 15:05:09 -0700 [thread overview]
Message-ID: <CA+P7+xqdWbERVQenZJTLyirBy2VFrKV2-uBOxB1CwcWs+gy43A@mail.gmail.com> (raw)
In-Reply-To: <xmqqvay26r8u.fsf@gitster.mtv.corp.google.com>
On Sun, Sep 11, 2016 at 2:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jakub Narębski <jnareb@gmail.com> writes:
>
>> I wonder, if git-commit is to acquire such feature, what would be the
>> best interface. "git commit :0:./<path>"? "git commit -o -p <path>"
>> (that is, "git commit --only --patch <pathspec>")?
>
> Just do "git reset && git commit -p <pathspec>", I would say.
> Anything more elaborate would just confuse the end users.
>
Yes, I'm actually confused by "git commit <files>" *not* usinng what's
in the index already, so I think that isn't intuitive as is.
Thanks,
Jake
next prev parent reply other threads:[~2016-09-11 22:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 21:08 git commit -p with file arguments Christian Neukirchen
2016-09-09 10:54 ` Duy Nguyen
2016-10-05 10:26 ` Duy Nguyen
2016-10-05 11:38 ` Christian Neukirchen
2016-10-05 17:16 ` Junio C Hamano
2016-09-09 16:57 ` Jacob Keller
2016-09-09 17:05 ` Christian Neukirchen
2016-09-09 18:03 ` Junio C Hamano
2016-09-09 20:39 ` Jakub Narębski
2016-09-09 20:52 ` Christian Neukirchen
2016-09-10 9:52 ` Jakub Narębski
2016-09-11 21:50 ` Junio C Hamano
2016-09-11 22:05 ` Jacob Keller [this message]
2016-09-12 1:57 ` Junio C Hamano
2016-09-12 4:56 ` Jacob Keller
2016-09-12 21:14 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+P7+xqdWbERVQenZJTLyirBy2VFrKV2-uBOxB1CwcWs+gy43A@mail.gmail.com \
--to=jacob.keller@gmail.com \
--cc=chneukirchen@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).