From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 550EF1FADF for ; Thu, 18 Jan 2018 21:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753649AbeARVUc (ORCPT ); Thu, 18 Jan 2018 16:20:32 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:32789 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbeARVU1 (ORCPT ); Thu, 18 Jan 2018 16:20:27 -0500 Received: by mail-wm0-f54.google.com with SMTP id x4so4503569wmc.0 for ; Thu, 18 Jan 2018 13:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NSvQd/rll4pJwCKpVIBTv5pXHafJfSs4IsjGgxZWhXQ=; b=eJSzxgONyQ/70WqPYBzlSL31ISRoat43cmj2UU9v/J9QmyZNXQsisZ11SsuWJeHE+N q2FgaRiFVgzPnnMIxeXmbYxkEMB4mhqkDJS/lWvDy8qys4OS5b183xjyJN8rlP8OM3La KlcEHmPSlbY90akciJK4EYMaIbuV8T9h8qaz3P/8Cbv1KsQ/docRhCEXOGGMlpKodwrA O277dL2jcSeZ/zlwl1ytapOMmQsoIZvVi6aRGwGbdTEb96kyJKJB0KckAsJEpS7MEluB T5Z6hm9CsMW5C+kLP8M7CTk6NTBz0i5qKDJBikZUUwxF2UDHr9pkbMCsZZfapZQVhH6O 1DPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NSvQd/rll4pJwCKpVIBTv5pXHafJfSs4IsjGgxZWhXQ=; b=j1P9yht3uqJZNfUGVe8zcZUJTtGed++DTbLaP70Gh/hPKqCVdI+9kmEzljKDmDs/j+ Oia7DBfw1EZiyCLk9IvF6R59J/SHjJPKfv+N+FhJjShfkHKPE39/N3Em5nvuXGdcaDr7 o/48e/WR2N8NbVBpoifX9g6RTq/pAR+llCAp7X3EKSekmfeHGZUA/JsjhWx4ypsJ3vaD uT8YEvJNTqnb7bS0S7VhwaJCluDG5Na7rYIp/gSqC8DXTw3wihkK9eoToX5VAdjcm/R/ jqbjN4ebnT0AMOvMpfrn7IaXx173UoIN6qNS/8foYD6d0lPolRPexSuNY92oztEhz3jK R8/w== X-Gm-Message-State: AKwxyteM3PbmZVE/ibTlDMCcLRBWvkEFgasQJESNtZ/oeUE1oVDSHn1+ 8cWoTxBVL2VDY0Psq/s40chlmu4BCSvMvb5+Qcs5Iw== X-Google-Smtp-Source: ACJfBouueXCiRmU/LvHvbP+Jk3w5Av9P2stKW7xgHnS/Uc/XyqWcSHoMB8duHd1HV8l9TXrO+MbPSlKBdmU1HSUMDsw= X-Received: by 10.80.164.233 with SMTP id x38mr9741789edb.293.1516310424781; Thu, 18 Jan 2018 13:20:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.212.44 with HTTP; Thu, 18 Jan 2018 13:20:04 -0800 (PST) In-Reply-To: <20180118183618.39853-3-sbeller@google.com> References: <20180118183618.39853-1-sbeller@google.com> <20180118183618.39853-3-sbeller@google.com> From: Jacob Keller Date: Thu, 18 Jan 2018 13:20:04 -0800 Message-ID: Subject: Re: [PATCH 10/8] [DO NOT APPLY, but improve?] rebase--interactive: introduce "stop" command To: Stefan Beller Cc: Johannes Schindelin , Git mailing list , Junio C Hamano Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 18, 2018 at 10:36 AM, Stefan Beller wrote: > Jake suggested using "x false" instead of "edit" for some corner cases. > > I do prefer using "x false" for all kinds of things such as stopping > before a commit (edit only let's you stop after a commit), and the > knowledge that "x false" does the least amount of actions behind my back. > > We should have that command as well, maybe? > I agree. I use "x false" very often, and I think stop is probably a better solution since it avoids spawning an extra shell that will just fail. Not sure if stop implies too much about "stop the whole thing" as opposed to "stop here and let me do something manual", but I think it's clear enough. Thanks, Jake > Signed-off-by: Stefan Beller > --- > git-rebase--interactive.sh | 1 + > sequencer.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > index 3cd7446d0b..9eac53f0c5 100644 > --- a/git-rebase--interactive.sh > +++ b/git-rebase--interactive.sh > @@ -166,6 +166,7 @@ l, label