From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A78781F8C1 for ; Fri, 1 May 2020 21:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726660AbgEAVxq (ORCPT ); Fri, 1 May 2020 17:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgEAVxp (ORCPT ); Fri, 1 May 2020 17:53:45 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C35DCC061A0C for ; Fri, 1 May 2020 14:53:44 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id w188so3078454vkf.0 for ; Fri, 01 May 2020 14:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FctAiHgHECdogWUU9MmWFIwuvWozPDEsI8WubTMISjc=; b=M2Daz8Lq+S26hFt4dWhlLCfPwM6WGLt2gxqq1gKAS4xQJNz4toYnI9CYXAE7ZVyH9b q2yKcJfa2kJTe7m/u3QQf86DSWq5T7wb5pCH6vdgi1P4Vv/HM2SYAMs4/FPANqOAHj86 EIkCK/ppgyNJobU70Fnsy0yAOPRR48ZclLulVLfjHcJGyxK5PNzaY/DnBA0GjrO1/oYW EmntxOQw8KvEeWgRqdxLi8DsgHZYTHifNSh3tEzEU937xhA2ExTsTNz3sv3n84o58LRB n4eubviG3Hzf6dbn6Jn7KpHkyaavxQN7WJQamNWfZ8CnYgOpYVfmhnOfm0dY+BYe4LRQ M3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FctAiHgHECdogWUU9MmWFIwuvWozPDEsI8WubTMISjc=; b=fFy7ikfQvq52tRUeSX9dri1ok5guv31Rdl8hoUzKS1eUejMGVDbYoqHGWTAhLnNYBi /IG0oRfOaFXUjnvLphbxDtFbpmKTPt2nfIV1lFyudnVYt77GDutoS6UHRKe/WgFz3cHd 5EVwZS55qtuf8DSCce9DT5rbi0NQucKjgUpDbv/UL23j6ksUNrNaoHl4RSodHxlH5SGg hnJZB51Jk30nVuCyi4Pf6TSm0ug21Tu1UqxnK2GDuTnRt5tq+Pcily0/xT1TlfKUIVY0 PKB15nIxQ0QRXsoi/6NvW1NL451lzXmcXNjmN/zhSGfbkz2iTGloyh+rDFnDmUaA053x rfQg== X-Gm-Message-State: AGi0PuYwqPZUXQpF7BRRvZlhJlp0ppYVHTQdyzGNDiwG55E+Zna+Uw5k AdNgubnqfGFOzJlCoabhj7Pk6qrRIInLKZv2dWE= X-Google-Smtp-Source: APiQypLWWnwPZyGR+93kGs4iz82Fyq62HXgY697I9JhHgchdWIDgLvcBgOyECCJpO/zKKrZB/EyTgdLa5pXaPu+WsU8= X-Received: by 2002:a1f:16d5:: with SMTP id 204mr4243743vkw.20.1588370023965; Fri, 01 May 2020 14:53:43 -0700 (PDT) MIME-Version: 1.0 References: <20200425022045.1089291-1-jacob.e.keller@intel.com> In-Reply-To: From: Jacob Keller Date: Fri, 1 May 2020 14:53:32 -0700 Message-ID: Subject: Re: [PATCH 00/11] refactor git switch completion To: Junio C Hamano Cc: Jacob Keller , =?UTF-8?Q?SZEDER_G=C3=A1bor?= , Git mailing list , Jonathan Nieder Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Apr 30, 2020 at 3:57 PM Junio C Hamano wrote: > > Jacob Keller writes: > > > From: Jacob Keller > > > > completion support for git switch is subpar for a number of cases. Most > > notable is difference between these two completions: > > > > $git switch > > Display all 784 possibilities? (y or n) > > > > > > $git switch --track > > jk-refactor-git-switch-completion master` > > ... > > We've discussed that it may be a good idea to make sure that "switch > -c", "checkout -b" and "switch/checkout --orphan" complete the new > branch name the same way, but haven't done anything else. I'd very > much appreciate to see the patches reviewed by those involved more > in the completion script, before we decide to merge the topic to > 'next'. It is my intention to extend this series with a notion of reading the previous word on the command line, and using that to determine if we are completing an argument for an option. Thanks, Jake