From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7BA7B1F66E for ; Fri, 21 Aug 2020 16:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbgHUQ24 (ORCPT ); Fri, 21 Aug 2020 12:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728461AbgHUQ2t (ORCPT ); Fri, 21 Aug 2020 12:28:49 -0400 Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F6AC061795 for ; Fri, 21 Aug 2020 09:28:23 -0700 (PDT) Received: by mail-vs1-xe2f.google.com with SMTP id b26so1101120vsa.13 for ; Fri, 21 Aug 2020 09:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QC044wAJ9M/wh1gfwzFGiYfS1czFGXnJlhZ8Iaa7gH8=; b=bTxMDzKs5iOoCVXVBilNDpid/3VSAtdj2uBQvDCPfNLrb6FPRXHG5R2V70u3idQyXn te765vaj4L6AdbSjgbwt3jP4ITG5eiG9JhHuefjY9a89fnCJX8n3PimzdNsDfZ1E0csr +9CQaUUG2LfNOjySmWfTsYBUWn3+QzdfHn424h0lRHkObgkDpRKH+3Af4jykAEjAGdPP AIaF0b+e0AMm8LZWqNXpYOnZRdHe/RYqM8rCgeIxdSiueFwI+PdLNfqx+rx655pSwsDo 7HNSNzV0nMgYe/DmO/X/t8rMVxRj5qPwIr3KHgBoigg0GR7R/XafxFOMk2xOhuU6Fu/o 0wHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QC044wAJ9M/wh1gfwzFGiYfS1czFGXnJlhZ8Iaa7gH8=; b=MC/0YyTGH/UBx9yOybNcz4ifInfwu69HjDlJS7pPt1tAm5iVyp15QMgaPWfzf72Vh+ uNpTld/S+4TELnOIFPPEz5yr1OWc8n22dFMKMZEBp2vhtbEB23PXz4j6IBcNmrX5I5DC YGdJMfQby1PgeVd39C/rSrRq+msXZ7Y5LT2ZTFIwjyfTE2RIQobNFum5Vj7PMkbzcm7A 3qpPBh8CmbzoXAs3/GxvlV4rb2jDBv58eItG9UUV/OHHYeYrxvrn+uBjKQBRtVh2nK3P To7Y2tBvVbgT613ffB6hprTLuWMhstNmtyUb/4ckzkhRqvdjlD4w72xaWefRIBIkfXlT kBUA== X-Gm-Message-State: AOAM532tdWZywr+pV0TvEyqd+zxjw/JKUXwK/1H6klgOIFB7MKMpnlZc pFJSXdR4eqZG/QT5vmujRs2BsROyzSd0BwVzoRw= X-Google-Smtp-Source: ABdhPJwdabrKd5IROWUnKnMshGijL6s3XTSF6cWEjididyyV8ei/As4xL9ka4FAK1+UmiCv4Jf0YQ5zFz+R1xk535kk= X-Received: by 2002:a67:bb06:: with SMTP id m6mr2447496vsn.54.1598027303120; Fri, 21 Aug 2020 09:28:23 -0700 (PDT) MIME-Version: 1.0 References: <20200815002509.2467645-1-jacob.e.keller@intel.com> <20200815002509.2467645-3-jacob.e.keller@intel.com> <20200818174116.GA2473110@coredump.intra.peff.net> <20200821023335.GA3124022@coredump.intra.peff.net> In-Reply-To: From: Jacob Keller Date: Fri, 21 Aug 2020 09:28:11 -0700 Message-ID: Subject: Re: [RFC 3/3] refspec: add support for negative refspecs To: Junio C Hamano Cc: Jeff King , Jacob Keller , Git mailing list Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 21, 2020 at 9:19 AM Junio C Hamano wrote: > > Jeff King writes: > > > Yes, I'd agree we should be applying the negative refspecs first, and > > then de-duping / looking for collisions. Which I think is what the patch > > is doing currently. > > Good to see that we thought this through. The reasoning deserves to > be recorded somewhere (perhaps a comment just before making the call > to apply the negative refspec). > > Thanks. I am hoping to add a test case for this as well!