From: Jacob Keller <firstname.lastname@example.org> To: Mike Rappazzo <email@example.com> Cc: "Stefan Beller" <firstname.lastname@example.org>, "Nguyễn Thái Ngọc" <email@example.com>, firstname.lastname@example.org, "Git List" <email@example.com>, "Junio C Hamano" <firstname.lastname@example.org> Subject: Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head' Date: Thu, 13 Dec 2018 22:49:58 -0800 [thread overview] Message-ID: <CA+P7+xonxvfuhw4W+FUL87We8CaOwxsndFkN5bcgBhdsnZ5QAg@mail.gmail.com> (raw) In-Reply-To: <CANoM8SWQTAEYGiUC9PnWi8u9oAJYPcyiE5+5usoRvR7Vw2z0JA@mail.gmail.com> On Thu, Dec 13, 2018 at 1:16 PM Mike Rappazzo <email@example.com> wrote: > > On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller <firstname.lastname@example.org> wrote: > > > > > > The current situation is definitely a problem. If I am in a worktree, > > > > using "head" should be the same as "HEAD". > > > > By any chance, is your file system case insensitive? > > That is usually the source of confusion for these discussions. > > This behavior is the same for MacOS (High Sierra) and Windows 7. I > assume other derivatives of those act the same. > > On CentOS "head" is an ambiguous ref. If Windows and Mac resulted in > an ambiguous ref, that would also be OK, but as it is now, they return > the result of "HEAD" on the primary worktree. > Because refs are *not* case sensitive, and we know that "HEAD" should be per-worktree, it gets checked in the per-worktree refs section. But lowercase head is known to not be a per-worktree ref, so we then ask the main worktree about head. Since you happen to be on a case insensitive file system, it then finds refs/HEAD in the main refs worktree, and returns that. I don't understand why the CentOS shows it as ambiguous, unless you actually happen to have a ref named head. (possibly a branch?) I suspect we could improve things by attempting to figure out if our file system is case insensitive and warn users. However, I recall patches which tried this, and no suitable method was found. Partly because it's not just "case" that is the only problem. There might be things like unicode characters which don't get properly encoded, etc. The best solution would be to get a non-filesystem backed ref storage working that could be used in place of the filesystem. Thanks, Jake > > > > Maybe in worktree code we have a spillover between path > > resolution and ref namespace?
next prev parent reply other threads:[~2018-12-14 6:50 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-13 19:54 [PATCH 0/1] " Michael Rappazzo via GitGitGadget 2018-12-13 19:54 ` [PATCH 1/1] " Michael Rappazzo via GitGitGadget 2018-12-13 20:23 ` Duy Nguyen 2018-12-13 20:34 ` Mike Rappazzo 2018-12-13 20:43 ` Duy Nguyen 2018-12-13 20:47 ` Stefan Beller 2018-12-13 21:14 ` Mike Rappazzo 2018-12-14 0:33 ` brian m. carlson 2018-12-14 6:49 ` Jacob Keller [this message] 2018-12-14 7:37 ` Duy Nguyen 2018-12-14 17:22 ` Jacob Keller 2018-12-14 17:38 ` Duy Nguyen 2018-12-14 17:46 ` Duy Nguyen 2018-12-14 18:48 ` Jacob Keller 2018-12-14 18:47 ` Jacob Keller 2018-12-13 21:07 ` Mike Rappazzo 2018-12-14 3:31 ` Junio C Hamano 2018-12-14 10:36 ` [PATCH 0/1] " Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+P7+xonxvfuhw4W+FUL87We8CaOwxsndFkN5bcgBhdsnZ5QAg@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/1] worktree refs: fix case sensitivity for '\''head'\''' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).