From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 75C4F1F403 for ; Sun, 16 Oct 2022 16:06:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="S2DZYekH"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiJPQGW (ORCPT ); Sun, 16 Oct 2022 12:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbiJPQGV (ORCPT ); Sun, 16 Oct 2022 12:06:21 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4BCA17AA0 for ; Sun, 16 Oct 2022 09:06:20 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id r14so12936844edc.7 for ; Sun, 16 Oct 2022 09:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nITRGEwsqJR/ZNGT5YJw0/tqNM3A+z0Q3O9VXmbgdH0=; b=S2DZYekHpevQkJqBEzO+12OIYUFSutPddtoAFlvU7RqimziRiZpwJQ9Izsch5hBA/5 uDbSueytfhwfItqAv2pp6SInCisTu26g/QITzizN0kpI8b9fUqzn+KZOk9vF+w8sO/bf m+Z9OeBaWDtUAckSk6yGrOQ3DtDq+4Wuvqml6zicuB0tCGfukAi+awQtpcRNauDs6Lf1 VMNU4JJbM84gwl4cyyhA3QFNm4Z3mp6/wEPIsuf+CgxKxG9cNYp4PP/d9mxZ7Ev38MBs bUiTqbo9ZxcjHSydBASSNIZ3JKk06WwUcEnmR49ESNyj2bgqwWfU4uARmRjwP1xmKVS/ t2vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nITRGEwsqJR/ZNGT5YJw0/tqNM3A+z0Q3O9VXmbgdH0=; b=d5iLKXxh3OR4ilRVzhTuOz7UXORyuLfFrHyWkvyrpD2+0CeOLNr2H9IEd0Lb/lcdWz HOSRbIViz6n6sBAdkmOjJvA1tavIbEQB2jF1jHalNrXrt+DX7VeiI07Jjvz6H7N4/z2R tlU57o0hSQXz64nVIc5za+2oHrDc5BEEeX9yLVl3gkMC2MFz3t2ZxxYt2KzN0eyzD9Wz EG2ToEW1wS7VZ1MoS80IgZ+QOvJasHNFNl+2jtPpXNqy+Bp1I35eXYKHBD5TJ+rxTkT9 HzzcbBQ29+AP32Wc2f8lo8IzmAMip3O0cYK1zP/ZdCY/V5M8wOeUnk5HaoNk11YnMb64 9mjQ== X-Gm-Message-State: ACrzQf1DoC/ukRqN/Y8maqi90vF4pODejxC1AuNYl5oIA1x+gNtP/DWg wMfOO4ixGrlu7ToOvfF9B9DSTaa0Tqvin41Fn3DSqaTnGPY= X-Google-Smtp-Source: AMsMyM6CUGPxy9bpLRlOuIPp8boh/FoKHAGJ3mBapd8GHcizoi8E0u2/ksowQkx8j1qn0qhDXsw/ejp0urwPfSiDTHo= X-Received: by 2002:a05:6402:2793:b0:45c:d273:8c18 with SMTP id b19-20020a056402279300b0045cd2738c18mr6917989ede.337.1665936379313; Sun, 16 Oct 2022 09:06:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Skrab Sah Date: Sun, 16 Oct 2022 21:36:07 +0530 Message-ID: Subject: Re: [PATCH v2] abspath.h file is generated by makeheaders tool To: =?UTF-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Cc: skrab-sah via GitGitGadget , git@vger.kernel.org, =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org > This will break cross-compilation. sorry, it was not in my mind. > At the very least, we needs to use either HOSTCC (likes linux project), > HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile > makeheaders > > So, something like (not tested, whatsoever): > > CC_FOR_BUILD = $(CC) > CFLAGS_FOR_BUILD = $(CFLAGS) > LDFLAGS_FOR_BUILD = $(LDFLAGS) > QUIET_HOSTCC = echo ' ' HOSTCC $@; > QUIET_MAKEHEADERS = echo ' ' MAKEHEADERS $@; > > makeheaders: tools/makeheaders.c > $(QUIET_HOSTCC)$(CC_FOR_BUILD) -o $@ $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $< > > abspath.h: abspath.c makeheaders > $(QUIET_MAKEHEADERS)./makeheaders $< Ok, as you suggested above, I will modify the patch according to it. If anyone suggests it will be good or not, I have another way to do it. What if we put the makeheaders tool executable in an online platform and then put it in Makefile to download it over the internet according to the system.