From: Robin Dupret <robin.dupret@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Robin Dupret <robin.dupret@hey.com>
Subject: Re: [PATCH] http-backend: remove a duplicated code branch
Date: Tue, 26 Oct 2021 21:04:25 +0200 [thread overview]
Message-ID: <CA+G124Xci1bGG1uxt35gr9ede11ix10CtLmmWcT+eYNCDSN6Xw@mail.gmail.com> (raw)
In-Reply-To: <xmqqsfwp2j6o.fsf@gitster.g>
> Did you mean to send the same patch text (but with an updated log
> message)? Just making sure.
Yes, exactly.
> We are all imperfect human and anything we do is merely "trying to"
Fair point. :-) Do you want me to resend the patch without this part
or is it ok ?
Thank you !
Le lun. 25 oct. 2021 à 17:55, Junio C Hamano <gitster@pobox.com> a écrit :
>
> Robin Dupret <robin.dupret@gmail.com> writes:
>
> > Try to make reading the computation of the gzipped flag a bit more
> > natural.
>
> ... and did you succeed? ;-)
>
> We are all imperfect human and anything we do is merely "trying to",
> so let's not say "try to", unless the change is so involved that it
> is hard to judge if the result has succeeded in trying.
>
> Did you mean to send the same patch text (but with an updated log
> message)? Just making sure.
>
> Thanks; will queue.
>
> > Signed-off-by: Robin Dupret <robin.dupret@hey.com>
> > ---
> > http-backend.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/http-backend.c b/http-backend.c
> > index e7c0eeab23..3d6e2ff17f 100644
> > --- a/http-backend.c
> > +++ b/http-backend.c
> > @@ -466,9 +466,7 @@ static void run_service(const char **argv, int buffer_input)
> > struct child_process cld = CHILD_PROCESS_INIT;
> > ssize_t req_len = get_content_length();
> >
> > - if (encoding && !strcmp(encoding, "gzip"))
> > - gzipped_request = 1;
> > - else if (encoding && !strcmp(encoding, "x-gzip"))
> > + if (encoding && (!strcmp(encoding, "gzip") || !strcmp(encoding, "x-gzip")))
> > gzipped_request = 1;
> >
> > if (!user || !*user)
next prev parent reply other threads:[~2021-10-26 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 19:25 [PATCH] http-backend: remove a duplicated code branch Robin Dupret
2021-10-11 19:25 ` Robin Dupret
2021-10-12 2:27 ` Jeff King
2021-10-12 9:07 ` Ævar Arnfjörð Bjarmason
2021-10-12 17:18 ` Junio C Hamano
2021-10-24 16:28 ` Robin Dupret
2021-10-24 16:28 ` [PATCH] http-backend: remove a duplicated code branch Robin Dupret
2021-10-25 15:55 ` Junio C Hamano
2021-10-26 19:04 ` Robin Dupret [this message]
2021-10-12 17:15 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-10-24 17:23 Robin Dupret
2021-10-24 17:29 ` Robin Dupret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+G124Xci1bGG1uxt35gr9ede11ix10CtLmmWcT+eYNCDSN6Xw@mail.gmail.com \
--to=robin.dupret@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.dupret@hey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).