From: Hariom verma <hariom18599@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>, johannes.schindelin@gmx.de
Subject: Re: [PATCH 2/3] t5509: initialized `pushee` as bare repository
Date: Sun, 23 Feb 2020 04:24:23 +0530 [thread overview]
Message-ID: <CA+CkUQ8SrmvFJF_Wn-E-49W2Gi8p0qxVr99SgTWyFfA0t6iJaA@mail.gmail.com> (raw)
In-Reply-To: <xmqqo8tym6sr.fsf@gitster-ct.c.googlers.com>
On Mon, Feb 17, 2020 at 5:19 AM Junio C Hamano <gitster@pobox.com> wrote:
> What I suggested was somewhat different, though.
>
> 1) get_main_worktree() fix you have as [1/3] in the current round.
>
> 2) fix `.denyCurrentBranch` for unborn branches in the primary
> worktree, new tests for the cases I outlined in the message you
> are responding to, and adjusting the test (i.e. what you have
> as [2/3] in the current round).
>
> 3) fix `.denyCurrentBranch` to pay attention to HEAD of not just
> the primary worktree but of all the worktrees, and add tests.
I doubt that it's possible to solve these 2 issues separately.
As dscho said: "a fix for one bug would be a fix for the other, and
(probably) vice versa."
As I discussed with dscho, the best possible solution for this
situation is to demonstrate the bug and fix it in succeeding commit.
I have sent this v2[1] for this patch.
Thanks,
Hariom
[1]: https://lore.kernel.org/git/pull.535.v2.git.1582410908.gitgitgadget@gmail.com/
next prev parent reply other threads:[~2020-02-22 22:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:59 [PATCH 0/3] [GSoC] receive.denyCurrentBranch: respect all worktrees Hariom Verma via GitGitGadget
2020-02-13 18:59 ` [PATCH 1/3] get_main_worktree(): allow it to be called in the Git directory Hariom Verma via GitGitGadget
2020-02-13 18:59 ` [PATCH 2/3] t5509: initialized `pushee` as bare repository Hariom Verma via GitGitGadget
2020-02-13 20:14 ` Junio C Hamano
2020-02-13 20:34 ` Junio C Hamano
2020-02-14 11:59 ` Johannes Schindelin
2020-02-14 15:03 ` Junio C Hamano
2020-02-15 21:52 ` Hariom verma
2020-02-16 23:49 ` Junio C Hamano
2020-02-22 22:54 ` Hariom verma [this message]
2020-02-13 18:59 ` [PATCH 3/3] receive.denyCurrentBranch: respect all worktrees Hariom Verma via GitGitGadget
2020-02-22 22:35 ` [PATCH v2 0/4] [GSoC] " Hariom Verma via GitGitGadget
2020-02-22 22:35 ` [PATCH v2 1/4] get_main_worktree(): allow it to be called in the Git directory Hariom Verma via GitGitGadget
2020-02-22 22:35 ` [PATCH v2 2/4] t5509: initialized `pushee` as bare repository Hariom Verma via GitGitGadget
2020-02-23 6:24 ` Junio C Hamano
2020-02-22 22:35 ` [PATCH v2 3/4] bug: denyCurrentBranch and unborn branch with ref namespace Hariom Verma via GitGitGadget
2020-02-23 6:10 ` Junio C Hamano
2020-02-22 22:35 ` [PATCH v2 4/4] receive.denyCurrentBranch: respect all worktrees Hariom Verma via GitGitGadget
2020-02-23 6:18 ` Junio C Hamano
2020-02-23 18:57 ` [PATCH v3 0/3] [GSoC] " Hariom Verma via GitGitGadget
2020-02-23 18:57 ` [PATCH v3 1/3] get_main_worktree(): allow it to be called in the Git directory Hariom Verma via GitGitGadget
2020-02-24 1:42 ` Eric Sunshine
2020-02-24 11:09 ` Hariom verma
2020-02-24 17:00 ` Eric Sunshine
2020-02-24 18:58 ` Johannes Schindelin
2020-02-24 22:27 ` Eric Sunshine
2020-02-27 15:58 ` Johannes Schindelin
2020-02-24 19:13 ` Junio C Hamano
2020-02-23 18:57 ` [PATCH v3 2/3] t5509: use a bare repository for test push target Hariom Verma via GitGitGadget
2020-02-23 18:57 ` [PATCH v3 3/3] receive.denyCurrentBranch: respect all worktrees Hariom Verma via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+CkUQ8SrmvFJF_Wn-E-49W2Gi8p0qxVr99SgTWyFfA0t6iJaA@mail.gmail.com \
--to=hariom18599@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).