From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mike Hommey <mh@glandium.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Fwd: Possibly nicer pathspec syntax?
Date: Tue, 7 Feb 2017 18:49:24 -0800 [thread overview]
Message-ID: <CA+55aFxTwK=+oJT_zujKLWEho9CoL6u6LTLDEP+wzjFDx=JQyQ@mail.gmail.com> (raw)
In-Reply-To: <20170208024042.trmkjm4jnxidcflg@glandium.org>
On Tue, Feb 7, 2017 at 6:40 PM, Mike Hommey <mh@glandium.org> wrote:
>
> As such, the default positive match should be ':/' (which is shorter and
> less cumbersome than ':(top)', btw)
So that's what my patch does.
However, it's actually very counter-intuitive in a subdirectory.
Git doesn't do much of that, but let me give you an example from the
kernel. Again, this is not an example of anything I would do (because
I'm always at the top), but:
[torvalds@i7 linux]$ cd drivers/
[torvalds@i7 drivers]$ ll
.. whee, *lots* of diorectories ..
.. lets see what happened in net/ ..
[torvalds@i7 drivers]$ git diff -M --dirstat=1,cumulative
v4.10-rc6..v4.10-rc7 -- net/
7.4% drivers/net/ethernet/adaptec/
47.9% drivers/net/ethernet/cadence/
7.1% drivers/net/ethernet/emulex/benet/
1.1% drivers/net/ethernet/freescale/
3.6% drivers/net/ethernet/mellanox/mlx4/
23.5% drivers/net/ethernet/mellanox/mlx5/core/
27.2% drivers/net/ethernet/mellanox/
92.5% drivers/net/ethernet/
5.3% drivers/net/wireless/intel/iwlwifi/mvm/
5.9% drivers/net/wireless/intel/iwlwifi/
100.0% drivers/net/
.. let's see what happened *outside* of net/ ..
[torvalds@i7 drivers]$ git diff -M --dirstat=1,cumulative
v4.10-rc6..v4.10-rc7 -- :^net/
2.4% arch/arm64/crypto/
2.1% arch/powerpc/include/asm/
1.5% arch/powerpc/kernel/
3.9% arch/powerpc/
3.5% arch/sparc/kernel/
4.1% arch/sparc/
8.3% arch/x86/events/intel/
1.7% arch/x86/kernel/cpu/mcheck/
1.6% arch/x86/kernel/cpu/microcode/
3.3% arch/x86/kernel/cpu/
3.8% arch/x86/kernel/
1.0% arch/x86/platform/efi/
13.3% arch/x86/
24.0% arch/
1.1% drivers/base/
2.9% drivers/dma/
12.3% drivers/gpu/drm/i915/
1.0% drivers/gpu/drm/nouveau/
16.2% drivers/gpu/drm/
3.9% drivers/hid/
1.6% drivers/iio/
2.3% drivers/regulator/
...
Notice? When you say "show only the net subdirectory" it does the
obvious thing relative to the current working directory, but if you
say "show everything _but_ the net subdirectory" it suddenly starts
showing other things.
Now, it would be easy enough to say "if you don't give a positive
path, we'll just use the empty path that matches the negative paths".
So if you ask for a negative relative "net" directory, we'll use the
relative empty path. And if you ask for a negative absolute path,
we'll use the empty absolute path.
It's a couple of lines more, and I think it might avoid some confusion.
And I suspect almost nobody has ever done any of this before,. because
the syntax was/is so cumbersome.
Linus
next prev parent reply other threads:[~2017-02-08 2:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFyznf1k=iyiQx6KLj3okpid0-HexZWsVkxt7LqCdz+O5A@mail.gmail.com>
2017-02-07 23:12 ` Fwd: Possibly nicer pathspec syntax? Linus Torvalds
2017-02-08 0:54 ` Junio C Hamano
2017-02-08 1:48 ` Linus Torvalds
2017-02-08 2:40 ` Mike Hommey
2017-02-08 2:49 ` Linus Torvalds [this message]
2017-02-08 3:06 ` Mike Hommey
2017-02-08 2:42 ` Junio C Hamano
2017-02-08 3:02 ` Linus Torvalds
2017-02-08 3:12 ` Junio C Hamano
2017-02-08 3:28 ` Linus Torvalds
2017-02-08 4:42 ` Junio C Hamano
2017-02-08 5:12 ` Linus Torvalds
2017-02-08 6:39 ` Duy Nguyen
2017-02-08 17:39 ` Junio C Hamano
2017-02-08 21:11 ` Junio C Hamano
2017-02-09 13:48 ` Duy Nguyen
2017-02-09 13:27 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxTwK=+oJT_zujKLWEho9CoL6u6LTLDEP+wzjFDx=JQyQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).