From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Johan Hovold <johan@kernel.org>,
Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Kevin Daudt <me@ikke.info>, Junio C Hamano <gitster@pobox.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: body-CC-comment regression
Date: Fri, 17 Feb 2017 09:38:17 -0800 [thread overview]
Message-ID: <CA+55aFxPsRXKn=4jXUdPy1hh3iHagjoxMcpA5K-ENA-NtdnF-A@mail.gmail.com> (raw)
In-Reply-To: <vpq7f4pdkjp.fsf@anie.imag.fr>
On Fri, Feb 17, 2017 at 5:16 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
>
> I mostly agree for the SoB, but why should a Cc tag have only one email?
Because changing that clearly broke real and useful behavior.
The "multiple email addresses" thing is bogus and wrong. Just don't do it.
How would you even parse it sanely? Are the Cc: lines now
SMTP-compliant with the whole escaping and all the usual "next line"
rules?
For example, in email, the rule for "next line" is that if you're in a
header block, and it starts with whitespace, then it's a continuation
of the last line.
That's *not* how Cc: lines work in commit messages. They are all
individual lines, and we have lots of tools (mainly just scripts with
grepping) that simply depend on it.
So this notion that the bottom of the commit message is some email
header crap is WRONG.
Stop it. It caused bugs. It's wrong. Don't do it.
Linus
prev parent reply other threads:[~2017-02-17 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 17:49 body-CC-comment regression Johan Hovold
2017-02-16 17:59 ` Junio C Hamano
2017-02-16 18:14 ` Johan Hovold
2017-02-16 18:16 ` Matthieu Moy
2017-02-17 11:06 ` Johan Hovold
2017-02-17 13:16 ` Matthieu Moy
2017-02-17 16:42 ` Johan Hovold
2017-02-17 16:58 ` Matthieu Moy
2017-02-17 17:30 ` Johan Hovold
2017-02-17 18:18 ` Junio C Hamano
2017-02-17 18:23 ` Johan Hovold
2017-02-17 18:28 ` Junio C Hamano
2017-02-17 18:44 ` Matthieu Moy
2017-02-17 20:05 ` Junio C Hamano
2017-02-17 20:20 ` Matthieu Moy
2017-02-17 22:22 ` Junio C Hamano
2017-02-17 23:04 ` Junio C Hamano
2017-02-20 11:44 ` [PATCH v2] send-email: only allow one address per body tag Johan Hovold
2017-02-20 12:10 ` Matthieu Moy
2017-02-23 18:53 ` Junio C Hamano
2017-02-26 20:45 ` Matthieu Moy
2017-02-17 17:38 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxPsRXKn=4jXUdPy1hh3iHagjoxMcpA5K-ENA-NtdnF-A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).