From: "Drew DeVault" <sir@cmpwn.com>
To: "Christian Couder" <christian.couder@gmail.com>
Cc: "git" <git@vger.kernel.org>
Subject: Re: Proposal: server-advertised config options
Date: Mon, 07 Sep 2020 14:49:46 -0400 [thread overview]
Message-ID: <C5HD1Z4AEVWJ.2QPVVNIQGBAM7@homura> (raw)
In-Reply-To: <CAP8UFD1wS9GDhek0Rbo=E+csf_u32D+22EsLom=AFu5D1pAYYg@mail.gmail.com>
On Mon Sep 7, 2020 at 2:49 PM EDT, Christian Couder wrote:
> > Upon cloning, each recommended config option would be displayed to the
> > user, and they would be prompted ([Y/n]) to agree to set that value in
> > the config file for that repository.
>
> Maybe the default should be "N" instead of "Y" for more security. Also
> when not using a terminal, it should do nothing by default too.
Ack, ack.
> > Additionally, there would be a config option which white-lists a
> > list of config options which are automatically agreed to without
> > prompting,
>
> This might be dangerous if this option can also be proposed by the
> server, as it could first propose a big list of white listed options
> to the client.
Aye, I think we'd prevent the server from advertising that option
period, as a hard-coded restriction.
> My opinion is that you might not want to start working on all the
> above at once. It might be better to start small and safe while
> leaving the door open to further improvements.
While this work could easily be (and ought to be) broken up into small
commits which introduce it one piece at a time, I'm not sure that any
subset of the pieces is *shippable*. Do you have a suggestion for how it
could be broken up into small, shippable pieces?
next prev parent reply other threads:[~2020-09-07 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:52 Proposal: server-advertised config options Drew DeVault
2020-09-07 18:49 ` Christian Couder
2020-09-07 18:49 ` Drew DeVault [this message]
2020-09-07 18:51 ` Junio C Hamano
2020-09-07 19:23 ` Drew DeVault
2020-09-07 20:52 ` brian m. carlson
2020-09-08 14:14 ` Drew DeVault
2020-09-10 1:45 ` brian m. carlson
2020-09-10 4:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5HD1Z4AEVWJ.2QPVVNIQGBAM7@homura \
--to=sir@cmpwn.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).