git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Drew DeVault" <sir@cmpwn.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: do not prompt for In-Reply-To
Date: Fri, 28 Aug 2020 17:01:46 -0400	[thread overview]
Message-ID: <C58XLLAE3SMA.3T1C6DXZ4VSWA@homura> (raw)
In-Reply-To: <xmqqk0xio59r.fsf@gitster.c.googlers.com>

On Fri Aug 28, 2020 at 5:00 PM EDT, Junio C Hamano wrote:
> "Drew DeVault" <sir@cmpwn.com> writes:
>
> > "You can give an empty answer if you are not responding to any message"
> > could confuse users, because they might think -v2 is a "response", or
> > maybe they've written the patch in response to a discussion on the
> > -users mailing list, or any other number of reasons.
>
> "Type the value you would have given to --in-reply-to command line
> option (if you forgot to use it), or leave this field empty"
> perhaps? Those who do not know should be able to learn what
> "--in-reply-to" is. A prompt help is not the place to do a
> documentation.

This would be better, yeah, but at that point it's pretty weird, like
why are we prompting for this CLI flag and not any others? The answer is
just for legacy reasons. There's no inherent justification for it.

> > I hate to be a nuisance over such a seemingly simple problem, but there
> > are a lot of new users who are struggling here and I care about their
> > struggle. What path should we take to fixing this issue for them?
>
> The ideal way would be to craft step (0) well enough so that new
> users trigger the To: prompt in the first place, which would
> automatically make the problem disappear ;-)

Do you mean teaching users how to use --to upfront? Honestly the prompt
seems totally fine to me, there's nothing wrong with a use-case which
calls for typing your To address into the prompt. Hell, often I'll use
it, or I'll use --annotate and write my To addresses in vim.

  reply	other threads:[~2020-08-28 21:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 17:55 [PATCH] send-email: do not prompt for In-Reply-To Drew DeVault
2020-08-27 19:04 ` Junio C Hamano
2020-08-27 19:08   ` Junio C Hamano
2020-08-27 19:14     ` Drew DeVault
2020-08-27 19:20       ` Carlo Marcelo Arenas Belón
2020-08-27 19:23         ` Drew DeVault
2020-08-27 19:32           ` Carlo Marcelo Arenas Belón
2020-08-27 19:34         ` Junio C Hamano
2020-08-27 19:34           ` Drew DeVault
2020-08-27 19:46             ` Carlo Arenas
2020-08-27 22:02           ` Carlo Marcelo Arenas Belón
2020-08-27 22:57             ` Junio C Hamano
2020-08-27 22:59               ` Drew DeVault
2020-08-27 23:05                 ` Drew DeVault
2020-08-28  1:02                   ` Junio C Hamano
2020-08-28  1:10                     ` Drew DeVault
2020-08-28  1:44                     ` Raymond E. Pasco
2020-08-28  1:56                       ` Drew DeVault
2020-08-27 23:23                 ` Junio C Hamano
2020-08-27 23:24                   ` Drew DeVault
2020-08-28 18:39               ` Drew DeVault
2020-08-28 20:58                 ` Raymond E. Pasco
2020-08-28 21:00                 ` Junio C Hamano
2020-08-28 21:01                   ` Drew DeVault [this message]
2020-08-28 21:33                     ` Junio C Hamano
2020-08-28 21:35                       ` Drew DeVault
2020-08-27 19:21       ` Junio C Hamano
2020-08-27 19:22         ` Drew DeVault
2020-08-27 19:15   ` Drew DeVault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C58XLLAE3SMA.3T1C6DXZ4VSWA@homura \
    --to=sir@cmpwn.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).