From: "Tom Miller" <jackerran@gmail.com>
To: "Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>
Cc: "Tom Miller" <jackerran@gmail.com>, <git@vger.kernel.org>
Subject: Re: Propose promoting 'contrib/rerere-train.sh' to command
Date: Sun, 22 Dec 2019 07:14:55 -0600 [thread overview]
Message-ID: <BZBZ3Y9WU7J7.3PGDZKEYVQ165@penguin> (raw)
In-Reply-To: <20191222075836.GA3425263@coredump.intra.peff.net>
On Sun Dec 22, 2019 at 2:58 AM, Jeff King wrote:
> On Sat, Dec 21, 2019 at 03:52:53PM -0800, Junio C Hamano wrote:
>
>
> > Jeff King <peff@peff.net> writes:
> >
> > > The situations where I need rerere-train don't come up often, but when
> > > they do, it has always worked easily and without hiccups for me. So
> > > perhaps there are lurking gotchas that Junio might know about, but AFAIK
> > > the quality is high enough for it to be part of normal Git.
> >
> > I actually suspect that rewriting has a high chance of initially
> > degrading the quality, so we should take a two step approach if we
> > really want it as part of the core distribution. As to the UI, I
> > think "git rerere train a..b" would be a good one, but if the
> > scripted version is of high quality (I haven't looked at it for a
> > long time---even though I used it for a couple of times a year in
> > recent years), perhaps we can add it as "git-rerere--train"
> > subcommand that is spawned from "builtin/rerere.c" for the first
> > cut?
>
>
> Yeah, I'd be pretty happy with that, too.
>
>
> I just suspect its ultimate fate is conversion to C, given the general
> trend. And converting it to C that just calls out to other git commands
> via run_command would presumably behave just like the original, leaving
> the more challenging and error-prone conversion for later. Hopefully any
> upgrade to "real Git command" would include some tests, though. :)
>
>
> -Peff
Thanks for the feedback everyone! This is roughly the feedback I
expected. I think moving the shell version first will give more time to
focus on getting a strong test harness in place and a some decent
documentation. I happy with doing this in a multi phase approach as it
introduces less risk. When I get to the point of writing it in C I will
try to do the work internally by looking at commits as Jeff has
suggested, and fall back to run commands if I have to.
next prev parent reply other threads:[~2019-12-22 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 2:17 Propose promoting 'contrib/rerere-train.sh' to command Tom Miller
2019-12-21 17:00 ` Philip Oakley
2019-12-21 17:37 ` Philip Oakley
2019-12-21 19:31 ` Jeff King
2019-12-21 23:52 ` Junio C Hamano
2019-12-22 7:58 ` Jeff King
2019-12-22 13:14 ` Tom Miller [this message]
2020-01-01 22:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BZBZ3Y9WU7J7.3PGDZKEYVQ165@penguin \
--to=jackerran@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).