From: "Mazo, Andrey" <amazo@checkvideo.com>
To: Junio C Hamano <gitster@pobox.com>, Luke Diamand <luke@diamand.org>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Git mailing list" <git@vger.kernel.org>,
"Romain Merland" <merlorom@yahoo.fr>,
"Miguel Torroja" <miguel.torroja@gmail.com>,
"Lars Schneider" <larsxschneider@gmail.com>,
"George Vanburgh" <gvanburgh@bloomberg.net>
Subject: Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none
Date: Wed, 23 May 2018 16:41:34 +0000 [thread overview]
Message-ID: <BYAPR08MB38451D101964D3B4D10436EBDA6B0@BYAPR08MB3845.namprd08.prod.outlook.com> (raw)
In-Reply-To: <xmqqk1rvw2i1.fsf@gitster-ct.c.googlers.com>
> The last one (i.e. "even if it is verbose, if fileSize is not
> reported, do not write the verbose output") does not look like it is
> limited to the unshelve feature, so it might, even though it is a
> one-liner, deserve to be a separate preparatory patch if you want.
> But I do not feel strongly about either way.
This was actually discussed in a separate thread [1] some time ago with patches proposed by Thandesha and me.
I haven't yet got time to cook a final patch, which addresses both Thandesha's and mine use-cases though,
so this wasn't submitted to Junio yet.
In the meantime, I guess, one of the patches [2] from that thread can be taken as is.
[1] "[BUG] git p4 clone fails when p4 sizes does not return 'fileSize' key"
https://public-inbox.org/git/CAJJpmi-pLb4Qcka5aLKXA8B1VOZFFF+OAQ0fgUq9YviobRpYGg@mail.gmail.com/t/#mee2ec50a40242089741f808f06214a44278055b3
[2] "[PATCH 1/1] git-p4: fix `sync --verbose` traceback due to 'fileSize'"
https://public-inbox.org/git/2e2b2add4e4fffa4228b8ab9f6cd47fa9bf25207.1523981210.git.amazo@checkvideo.com/
Thank you,
Andrey Mazo
next prev parent reply other threads:[~2018-05-23 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 8:41 [PATCH 0/1] git-p4: unshelving: fix problem with newer P4 Luke Diamand
2018-05-22 8:41 ` [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none Luke Diamand
2018-05-22 10:15 ` SZEDER Gábor
2018-05-22 13:02 ` Luke Diamand
2018-05-23 2:05 ` Junio C Hamano
2018-05-23 7:21 ` [PATCHv5 0/1] git-p4: unshelve: fix problem with newer p4d Luke Diamand
2018-05-23 7:21 ` [PATCHv5 1/1] git-p4: add unshelve command Luke Diamand
2018-05-23 16:41 ` Mazo, Andrey [this message]
2018-05-23 19:12 ` [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none Luke Diamand
2018-05-23 19:38 ` Mazo, Andrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR08MB38451D101964D3B4D10436EBDA6B0@BYAPR08MB3845.namprd08.prod.outlook.com \
--to=amazo@checkvideo.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gvanburgh@bloomberg.net \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
--cc=merlorom@yahoo.fr \
--cc=miguel.torroja@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).