From: Joel Holdsworth <jholdsworth@nvidia.com>
To: Andrew Oakley <andrew@adoakley.name>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>,
Dorgon Chang <dorgonman@hotmail.com>,
Joachim Kuebart <joachim.kuebart@gmail.com>,
Daniel Levin <dendy.ua@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Luke Diamand <luke@diamand.org>, Ben Keene <seraphire@gmail.com>
Subject: RE: [PATCH 1/2] git-p4: print size values in appropriate units
Date: Fri, 17 Dec 2021 20:39:53 +0000 [thread overview]
Message-ID: <BN8PR12MB3361AD895447CF05A034D68BC8789@BN8PR12MB3361.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211217165627.49e931d6@ado-tr.dyn.home.arpa>
> If it's always bytes, why keep the suffix separate?
> You've left the "MB" in. The same thing happens elsewhere.
Both good points. I've resubmitted the patch set with the suggested amendments.
Joel
next prev parent reply other threads:[~2021-12-17 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 14:59 [PATCH 0/2] git-p4: improve formatting of numeric values Joel Holdsworth
2021-12-17 14:59 ` [PATCH 1/2] git-p4: print size values in appropriate units Joel Holdsworth
2021-12-17 16:56 ` Andrew Oakley
2021-12-17 20:39 ` Joel Holdsworth [this message]
2021-12-17 14:59 ` [PATCH 2/2] git-p4: show progress as an integer Joel Holdsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3361AD895447CF05A034D68BC8789@BN8PR12MB3361.namprd12.prod.outlook.com \
--to=jholdsworth@nvidia.com \
--cc=andrew@adoakley.name \
--cc=dendy.ua@gmail.com \
--cc=dorgonman@hotmail.com \
--cc=git@vger.kernel.org \
--cc=joachim.kuebart@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=luke@diamand.org \
--cc=seraphire@gmail.com \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).