From: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER
Date: Sun, 09 Oct 2016 21:08:41 -0700 [thread overview]
Message-ID: <BC856B6F-B18F-41AF-BE60-973B8CFFC973@apple.com> (raw)
In-Reply-To: <E0254A0C-8BEC-4B88-A352-BA075B49BFA7@joshtriplett.org>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
> On Oct 9, 2016, at 20:04, Josh Triplett <josh@joshtriplett.org> wrote:
>
> On October 9, 2016 7:53:23 PM PDT, Jeremy Huddleston Sequoia <jeremyhu@apple.com> wrote:
>> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae
>> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
>> CC: Josh Triplett <josh@joshtriplett.org>
>> CC: Junio C Hamano <gitster@pobox.com>
>
> Looks reasonable to me. Didn't realize git versions could have spaces.
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks, Josh.
If anyone feels strongly that they shouldn't, I'd be happy to change our DEF_VER patch to play nicer.
cf https://github.com/jeremyhu/git/commit/f99905d0752d923e5ec61e14c675a300c6d04284
>
>> t/t4014-format-patch.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
>> index 8d90a6e..33f6940 100755
>> --- a/t/t4014-format-patch.sh
>> +++ b/t/t4014-format-patch.sh
>> @@ -754,7 +754,7 @@ test_expect_success 'format-patch
>> --ignore-if-in-upstream HEAD' '
>> git format-patch --ignore-if-in-upstream HEAD
>> '
>>
>> -git_version="$(git --version | sed "s/.* //")"
>> +git_version="$(git --version | sed "s/git version //")"
>>
>> signature() {
>> printf "%s\n%s\n\n" "-- " "${1:-$git_version}"
>
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4465 bytes --]
next prev parent reply other threads:[~2016-10-10 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 2:53 [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER Jeremy Huddleston Sequoia
2016-10-10 3:04 ` Josh Triplett
2016-10-10 4:08 ` Jeremy Huddleston Sequoia [this message]
2016-10-10 13:10 ` Jeff King
2016-10-10 16:37 ` Jeremy Huddleston Sequoia
2016-10-10 16:46 ` Junio C Hamano
2016-10-10 16:42 ` Junio C Hamano
2016-10-10 17:01 ` Jeremy Huddleston Sequoia
2016-10-11 20:06 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC856B6F-B18F-41AF-BE60-973B8CFFC973@apple.com \
--to=jeremyhu@apple.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).