From: Jonathan Johnson <me@jondavidjohn.com>
To: git@vger.kernel.org
Subject: Bug in Submodule add
Date: Tue, 25 Sep 2012 22:18:05 -0600 [thread overview]
Message-ID: <BC634E06939C44239106E7A8DD229130@gmail.com> (raw)
I believe I have found an issue with the way `submodule add` detects a submodule that already exists in the repository.
To reproduce
1) add a git submodule in a specific location (we'll say it's at `./submodule/location`)
2) go through the normal steps of removing a submodule, as listed here - https://git.wiki.kernel.org/index.php/GitSubmoduleTutorial
3) Now the submodule is completely removed and there is no reference to it in .gitmodules or .git/config
4) Re-add a different repository at the same location (`./submodule/location`)
Expected - The new submodule repository will be set up at ./submodule/location and have the new repository as its origin
What Actually Happens - The new submodule uses the existing `$gitdir` (old repository) as the actual backing repository to the submodule, but the new repository is reflected in .gitmodules and .git/config.
So to recap, the result is that `git remote show origin` in the submodule shows a different origin than is in .gitmodules and .git/config
One simple step to remedy this would be to add the deletion of the backing repository from the .git/modules directory, but again, I think an actual command to take care of all of these steps is in order anyways. Not sure you want to encourage people poking around in the .git directory.
If this is already resolved in the newest versions, please disregard
Thanks!
Jonathan Johnson
http://jondavidjohn.com | me@jondavidjohn.com
next reply other threads:[~2012-09-26 4:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 4:18 Jonathan Johnson [this message]
2012-09-26 20:56 ` Bug in Submodule add Jens Lehmann
2012-09-29 23:04 ` [PATCH 0/2] Let "git submodule add" fail when .git/modules/<name> already exists Jens Lehmann
2012-09-29 23:05 ` [PATCH 1/2] Teach "git submodule add" the --name option Jens Lehmann
2012-09-29 23:07 ` [PATCH 2/2] submodule add: Fail when .git/modules/<name> already exists Jens Lehmann
2012-09-30 4:47 ` [PATCH 0/2] Let "git submodule add" fail " Junio C Hamano
2012-09-30 19:19 ` Jens Lehmann
2012-09-30 21:01 ` [PATCH v2 2/2] submodule add: Fail when .git/modules/<name> already exists unless forced Jens Lehmann
2012-10-01 0:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC634E06939C44239106E7A8DD229130@gmail.com \
--to=me@jondavidjohn.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).