From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2011, #02; Wed, 6)
Date: Mon, 11 Apr 2011 11:00:43 +0200 [thread overview]
Message-ID: <BANLkTinRRJAvMrbUUwGTcgK+9-Bh5QATcA@mail.gmail.com> (raw)
In-Reply-To: <4DA23551.4040304@web.de>
On Mon, Apr 11, 2011 at 00:55, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 10.04.2011 20:52, schrieb Ævar Arnfjörð Bjarmason:
>> On Wed, Apr 6, 2011 at 22:04, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> * jl/submodule-fetch-on-demand (2011-03-06) 7 commits
>>> (merged to 'next' on 2011-03-20 at a5e452d)
>>> + fetch/pull: Describe --recurse-submodule restrictions in the BUGS section
>>> + submodule update: Don't fetch when the submodule commit is already present
>>> + fetch/pull: Don't recurse into a submodule when commits are already present
>>> + Submodules: Add 'on-demand' value for the 'fetchRecurseSubmodule' option
>>> + config: teach the fetch.recurseSubmodules option the 'on-demand' value
>>> + fetch/pull: Add the 'on-demand' value to the --recurse-submodules option
>>> + fetch/pull: recurse into submodules when necessary
>>
>> This series needs to be fixed to not fail tests with GETTEXT_POISON=YesPlease.
>
> Maybe something like this? Junio, do you want me to squash the changes in
> the patch series and resend it or should I send a new commit?
Sorry about the short mail yesterday, I had to take care of something.
Anyway, that looks like it'll work, but the preferred way of doing it
is like it's done at the bottom of t3700-add.sh. I.e.:
test_expect_success 'git add --dry-run --ignore-missing of
non-existing file' '
test_must_fail git add --dry-run --ignore-missing track-this
ignored-file >actual.out 2>actual.err
'
test_expect_success C_LOCALE_OUTPUT 'git add --dry-run
--ignore-missing of non-existing file output' '
test_cmp expect.out actual.out &&
test_cmp expect.err actual.err
'
That is, split up each test into a test that tests the functionality
(i.e. exit codes) and one that tests the output.
That way we make sure that only things dependent on C locale output
are skipped under non-C locales.
Sometimes that's hard, in which case it's fine to just skip the entire thing.
next prev parent reply other threads:[~2011-04-11 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 20:04 What's cooking in git.git (Apr 2011, #02; Wed, 6) Junio C Hamano
2011-04-06 21:46 ` Jeff King
2011-04-10 18:52 ` Ævar Arnfjörð Bjarmason
2011-04-10 22:55 ` Jens Lehmann
2011-04-11 9:00 ` Ævar Arnfjörð Bjarmason [this message]
2011-04-11 17:55 ` Jens Lehmann
2011-04-11 18:11 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinRRJAvMrbUUwGTcgK+9-Bh5QATcA@mail.gmail.com \
--to=avarab@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).