From: Shawn Pearce <spearce@spearce.org>
To: "Steven E. Harris" <seh@panix.com>
Cc: git@vger.kernel.org
Subject: Re: Confused over packfile and index design
Date: Sat, 9 Apr 2011 10:45:41 -0400 [thread overview]
Message-ID: <BANLkTin8SXWC2cUqYvrPJrQWQKgMpRk4bg@mail.gmail.com> (raw)
In-Reply-To: <m28vvj7b0d.fsf@Spindle.sehlabs.com>
On Sat, Apr 9, 2011 at 10:30, Steven E. Harris <seh@panix.com> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>> Its meant to tell us how many bytes to malloc() in order to hold the
>> result of the libz inflate() call when the object is being read from
>> the packfile. That way we don't under or over allocate the result
>> buffer.
>
> Does Git always inflate the objects into an in-memory buffer?
Yes.
> As the
> size of these objects can be very large (given the variable-length size
> encoding), is there any provision to inflate the object to a temporary
> file?
Not currently. If you don't have enough memory for the malloc() buffer
of a big object, Git dies with an out of memory error.
--
Shawn.
next prev parent reply other threads:[~2011-04-09 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 23:58 Confused over packfile and index design Steven E. Harris
2011-04-09 0:20 ` Jeff King
2011-04-09 2:07 ` Shawn Pearce
2011-04-09 14:30 ` Steven E. Harris
2011-04-09 14:45 ` Shawn Pearce [this message]
2011-04-10 2:08 ` Nicolas Pitre
2011-04-10 20:10 ` Steven E. Harris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin8SXWC2cUqYvrPJrQWQKgMpRk4bg@mail.gmail.com \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=seh@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).