From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH] pathspec: rename per-item field has_wildcard to use_wildcard
Date: Wed, 6 Apr 2011 22:54:19 +0700 [thread overview]
Message-ID: <BANLkTikJ3=H_OgcNueMjnwwQ2W-2kamf=w@mail.gmail.com> (raw)
In-Reply-To: <7vr59gl581.fsf@alter.siamese.dyndns.org>
2011/4/6 Junio C Hamano <gitster@pobox.com>:
> * I was looking at the codepaths that would need to be touched in order
> to properly support the "magic pathspec" we have been discussing, and
> am leaning to conclude that all the users of get_pathspec() need to be
> rewritten to throw the remainder of argv[] at a function that fills a
> struct pathspec (in other words, a combination of get_pathspec() and
> init_pathspec()). Michael's "alternative approach to grep --full-tree"
> was operating at the get_pathspec() level, but that function is an
> interface to return an array of plain-vanilla strings only, and there
> is no place to hook richer per-item information on the elements. We
> would need "struct pathspec" in the function where we parse the argv[]
> and combine its elements with prefix.
I have started working on the conversion, but it may take a while
because in many places pathspec is still assumed a prefix (and handled
separately, which is not good for negative pathspec). Fundamental
support for magic pathspec and "top dir" notation probably do not need
get_pathspec() converted to struct pathspec.
--
Duy
next prev parent reply other threads:[~2011-04-06 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 22:10 [PATCH] pathspec: rename per-item field has_wildcard to use_wildcard Junio C Hamano
2011-04-06 15:54 ` Nguyen Thai Ngoc Duy [this message]
2011-04-06 17:13 ` Junio C Hamano
2011-04-06 19:52 ` Junio C Hamano
2011-04-07 11:09 ` Michael J Gruber
2011-04-07 13:00 ` Nguyen Thai Ngoc Duy
2011-04-07 19:44 ` Junio C Hamano
2011-04-07 19:47 ` Junio C Hamano
2011-04-08 8:29 ` Michael J Gruber
2011-04-08 19:40 ` Junio C Hamano
2011-04-07 12:51 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikJ3=H_OgcNueMjnwwQ2W-2kamf=w@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).