git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Matthias Aßhauer" <mha1993@live.de>
To: Rene Hutschenreuter <rene.hutschi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Security issues with openssl.exe
Date: Thu, 7 Oct 2021 18:28:12 +0200 (CEST)	[thread overview]
Message-ID: <AM0PR04MB6019545C115A7161E83881A8A5B19@AM0PR04MB6019.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAP_xbc=ag3+Bkvwtou4ZaYrnVm67kb37=oZEc5eTx8FsufhV=Q@mail.gmail.com>



On Thu, 7 Oct 2021, Rene Hutschenreuter wrote:

> Dear Sir or Madam,
>
> in our company we currently use GIT for programming tasks. Furthermore
> we use a VPN to connect to the company network.
>
> This VPN now prevents this connection due to a security problem with
> the "openssl.exe" in the GIT installation folder:
> - C:\Program Files\Git\mingw64\bin\openssl.exe
>
> Description-Text: In order to decrypt SM2 encrypted data an
> application is expected to call the API function EVP_PKEY_decrypt().
> Typically an application will call this function twice. The first
> time, on entry, the \"out\" parameter can be NULL and, on exit, the
> \"outlen\" parameter is populated with the buffer size required to
> hold the decrypted plaintext. The application can then allocate a
> sufficiently sized buffer and call EVP_PKEY_decrypt() again, but this
> time passing a non-NULL value for the \"out\" parameter. A bug in the
> implementation of the SM2 decryption code means that the calculation
> of the buffer size required to hold the plaintext returned by the
> first call to EVP_PKEY_decrypt() can be smaller than the actual size
> required by the second call. This can lead to a buffer overflow when
> EVP_PKEY_decrypt() is called by the application a second time with a
> buffer that is too small. A malicious attacker who is able present SM2
> content for decryption to an application could cause attacker chosen
> data to overflow the buffer by up to a maximum of 62 bytes altering
> the contents of other data held after the buffer, possibly changing
> application behaviour or causing the application to crash. The
> location of the buffer is application dependent but is typically heap
> allocated. Fixed in OpenSSL 1.1.1l (Affected 1.1.1-1.1.1k).
>
> Could you please provide a new Git version with an updated openssl.exe
> to fix this security issues?

This sounds like you're talking about Git for Windows and specifically
CVE-2021-3711. The Git for Windows team assesed the situation and 
determined the issue unlikely to be exploitable via Git's usage of 
OpenSSL.

The next regular Git for Windows release (likely 2.34.0, to be released 
soon after the 15th of November) will include OpenSSL 1.1.1l (or newer). In
the meantime you can try the latest snapshot[1] to get a Git for Windows
build that includes OpenSSL 1.1.1l.

[1] https://wingit.blob.core.windows.net/files/index.html

> Best regards
> René Hutschenreuter
> Developer
>

Best regards

Matthias Aßhauer

      reply	other threads:[~2021-10-07 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAP_xbc=PZq2Qs8KUVYJVofpTxucf43TeSm8Bk4Pxcb0wn70KjQ@mail.gmail.com>
2021-10-07 10:22 ` Security issues with openssl.exe Rene Hutschenreuter
2021-10-07 16:28   ` Matthias Aßhauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB6019545C115A7161E83881A8A5B19@AM0PR04MB6019.eurprd04.prod.outlook.com \
    --to=mha1993@live.de \
    --cc=git@vger.kernel.org \
    --cc=rene.hutschi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).