From: "Matthias Aßhauer" <mha1993@live.de>
To: "Raymond E. Pasco" <ray@ameretat.dev>, git@vger.kernel.org
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Stefan Beller <sbeller@google.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] ssh: add 'ssh.keyfile' option
Date: Thu, 23 Apr 2020 20:03:26 +0200 [thread overview]
Message-ID: <AM0PR04MB47715A57B110E14D6631EACDA5D30@AM0PR04MB4771.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200423112110.45405-1-ray@ameretat.dev>
>+ switch (variant) {
>+ case VARIANT_AUTO:
>+ BUG("VARIANT_AUTO passed to push_ssh_options");
Why do we keep replicating this all over push_ssh_options? The wording
very much sounds like it's a bug whenever VARIANT_AUTO gets passed to
push_ssh_options, no exceptions. In that case we should probably just
check for it once at the beginning of push_ssh_options instead of after
almost every single if. If there are valid cases where VARIANT_AUTO gets
passed to push_ssh_options we should probably clarify the wording as to
what parameter combinations are and aren't valid with VARIANT_AUTO.
I've included the Sign-Offs and Acks of the commits that introduced the
previous copies of this.[1][2] The previous discussion[3] on the mailing
list does not seem to mention the duplication.
[1] a3f5b66f: "ssh: 'simple' variant does not support -4/-6" 2017-11-20
[2] 3fa5e0d0: "ssh: 'simple' variant does not support --port" 2017-11-20
[3] https://lore.kernel.org/git/20170913215448.84674-1-bmwill@google.com/T/#u
Best regards
Matthias Aßhauer
next prev parent reply other threads:[~2020-04-23 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 6:41 [PATCH] ssh: add 'ssh.keyfile' option Raymond E. Pasco
2020-04-23 11:21 ` [PATCH v2] " Raymond E. Pasco
2020-04-23 17:24 ` Johannes Sixt
2020-04-23 19:32 ` Junio C Hamano
2020-04-24 3:24 ` Raymond E. Pasco
2020-04-23 18:03 ` Matthias Aßhauer [this message]
2020-04-23 19:38 ` Junio C Hamano
2020-04-24 4:33 ` Matthias Aßhauer
2020-04-25 9:43 ` [PATCH] connect.c: clarify BUG() messages in push_ssh_options Matthias Aßhauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB47715A57B110E14D6631EACDA5D30@AM0PR04MB4771.eurprd04.prod.outlook.com \
--to=mha1993@live.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=ray@ameretat.dev \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).