* [PATCH] Move deletion of configure generated files to distclean
@ 2008-06-21 0:57 shire
2008-06-21 1:28 ` Miklos Vajna
2008-06-21 1:35 ` Stephan Beyer
0 siblings, 2 replies; 4+ messages in thread
From: shire @ 2008-06-21 0:57 UTC (permalink / raw
To: git
Running "make clean" also requires a run of "./configure ..." again
because it deletes auto-generated files, which I found a little
unexpected. I figured I'd mention it as I'm not sure if this is
confusing for other users or intended functionality of "make clean"
vs. "make distclean", I would assume that the first would not revert
configuration changes.
Signed-off-by: Brian Shire <shire@tekrat.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index b003e3e..f868b0b 100644
--- a/Makefile
+++ b/Makefile
@@ -1346,6 +1346,7 @@ dist-doc:
### Cleaning rules
distclean: clean
+ $(RM) config.log config.mak.autogen config.mak.append config.status
config.cache
$(RM) configure
clean:
@@ -1355,7 +1356,6 @@ clean:
$(RM) $(TEST_PROGRAMS)
$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags
cscope*
$(RM) -r autom4te.cache
- $(RM) config.log config.mak.autogen config.mak.append config.status
config.cache
$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
--
1.5.6.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Move deletion of configure generated files to distclean
2008-06-21 0:57 [PATCH] Move deletion of configure generated files to distclean shire
@ 2008-06-21 1:28 ` Miklos Vajna
2008-06-21 1:35 ` Stephan Beyer
1 sibling, 0 replies; 4+ messages in thread
From: Miklos Vajna @ 2008-06-21 1:28 UTC (permalink / raw
To: shire; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Fri, Jun 20, 2008 at 05:57:45PM -0700, shire <shire@tekrat.com> wrote:
> Running "make clean" also requires a run of "./configure ..." again because
> it deletes auto-generated files, which I found a little unexpected. I
> figured I'd mention it as I'm not sure if this is confusing for other users
> or intended functionality of "make clean" vs. "make distclean", I would
> assume that the first would not revert configuration changes.
I remember I was surprised as well when first time I noticed this
behaviour, so I like your patch.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Move deletion of configure generated files to distclean
2008-06-21 0:57 [PATCH] Move deletion of configure generated files to distclean shire
2008-06-21 1:28 ` Miklos Vajna
@ 2008-06-21 1:35 ` Stephan Beyer
2008-06-21 7:33 ` shire
1 sibling, 1 reply; 4+ messages in thread
From: Stephan Beyer @ 2008-06-21 1:35 UTC (permalink / raw
To: shire; +Cc: git
Hi,
whitespace and linebreaks are broken in your patch.
(Just noticed because I needed a quick patch to test something and I
took yours.)
Regards,
Stephan
--
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Move deletion of configure generated files to distclean
2008-06-21 1:35 ` Stephan Beyer
@ 2008-06-21 7:33 ` shire
0 siblings, 0 replies; 4+ messages in thread
From: shire @ 2008-06-21 7:33 UTC (permalink / raw
To: Stephan Beyer; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Jun 20, 2008, at 6:35 PM, Stephan Beyer wrote:
> Hi,
>
> whitespace and linebreaks are broken in your patch.
> (Just noticed because I needed a quick patch to test something and I
> took yours.)
>
Doh, thanks! It appears there's no good simple way around the email
body being munged in os x's mail.app, and I was mislead in my initial
test email to myself. I'll either fix mail.app in the future or send
via some other mailer, I apologize for the obvious mistake despite
all the guidelines in the patches file. I've gone ahead and just
attached the patch to this email that should apply cleanly with git-am.
[-- Attachment #2: 0001-Move-deletion-of-configure-generated-files-to-distcl.patch --]
[-- Type: application/octet-stream, Size: 1026 bytes --]
From 6c3ec53f54ca346f7fff38ee4ef748cac3c0f488 Mon Sep 17 00:00:00 2001
From: Brian Shire <shire@99-204-10-66.area1.spcsdns.net>
Date: Fri, 20 Jun 2008 17:53:51 -0700
Subject: [PATCH] Move deletion of configure generated files to distclean
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index b003e3e..f868b0b 100644
--- a/Makefile
+++ b/Makefile
@@ -1346,6 +1346,7 @@ dist-doc:
### Cleaning rules
distclean: clean
+ $(RM) config.log config.mak.autogen config.mak.append config.status config.cache
$(RM) configure
clean:
@@ -1355,7 +1356,6 @@ clean:
$(RM) $(TEST_PROGRAMS)
$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags cscope*
$(RM) -r autom4te.cache
- $(RM) config.log config.mak.autogen config.mak.append config.status config.cache
$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
--
1.5.6.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-21 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-21 0:57 [PATCH] Move deletion of configure generated files to distclean shire
2008-06-21 1:28 ` Miklos Vajna
2008-06-21 1:35 ` Stephan Beyer
2008-06-21 7:33 ` shire
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).